Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: chrome/browser/app_controller_mac.mm

Issue 9814030: get rid of old options pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixes Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/app_controller_mac.mm
diff --git a/chrome/browser/app_controller_mac.mm b/chrome/browser/app_controller_mac.mm
index 28064d97e63bcc041cd874c71769ccaa0732e63c..a89a9d057cd0ff711b72b5e39309d254ede0fdaa 100644
--- a/chrome/browser/app_controller_mac.mm
+++ b/chrome/browser/app_controller_mac.mm
@@ -1214,29 +1214,12 @@ const AEEventClass kAECloudPrintUninstallClass = 'GCPu';
}
- (IBAction)orderFrontStandardAboutPanel:(id)sender {
- if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableUberPage)) {
- if (!aboutController_) {
- aboutController_ =
- [[AboutWindowController alloc] initWithProfile:[self lastProfile]];
-
- // Watch for a notification of when it goes away so that we can destroy
- // the controller.
- [[NSNotificationCenter defaultCenter]
- addObserver:self
- selector:@selector(aboutWindowClosed:)
- name:NSWindowWillCloseNotification
- object:[aboutController_ window]];
- }
-
- [aboutController_ showWindow:self];
+ if (Browser* browser = ActivateBrowser([self lastProfile])) {
+ // Show about tab in the active browser window.
+ browser->OpenAboutChromeDialog();
} else {
- if (Browser* browser = ActivateBrowser([self lastProfile])) {
- // Show about tab in the active browser window.
- browser->OpenAboutChromeDialog();
- } else {
- // No browser window, so create one for the about tab.
- Browser::OpenAboutWindow([self lastProfile]);
- }
+ // No browser window, so create one for the about tab.
+ Browser::OpenAboutWindow([self lastProfile]);
}
}

Powered by Google App Engine
This is Rietveld 408576698