Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Unified Diff: chrome/browser/resources/options/pack_extension_overlay.js

Issue 9814030: get rid of old options pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixes Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/pack_extension_overlay.js
diff --git a/chrome/browser/resources/options/pack_extension_overlay.js b/chrome/browser/resources/options/pack_extension_overlay.js
deleted file mode 100644
index f4b962ae1fb3ceb817ed9948f00270eca9dc266c..0000000000000000000000000000000000000000
--- a/chrome/browser/resources/options/pack_extension_overlay.js
+++ /dev/null
@@ -1,118 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-cr.define('options', function() {
- const OptionsPage = options.OptionsPage;
-
- /**
- * PackExtensionOverlay class
- * Encapsulated handling of the 'Pack Extension' overlay page.
- * @constructor
- */
- function PackExtensionOverlay() {
- OptionsPage.call(this, 'packExtensionOverlay',
- templateData.packExtensionOverlayTabTitle,
- 'packExtensionOverlay');
- }
-
- cr.addSingletonGetter(PackExtensionOverlay);
-
- PackExtensionOverlay.prototype = {
- // Inherit PackExtensionOverlay from OptionsPage.
- __proto__: OptionsPage.prototype,
-
- /**
- * Initialize the page.
- */
- initializePage: function() {
- // Call base class implementation to starts preference initialization.
- OptionsPage.prototype.initializePage.call(this);
-
- $('packExtensionDismiss').onclick = function(event) {
- OptionsPage.closeOverlay();
- };
- $('packExtensionCommit').onclick = function(event) {
- var extensionPath = $('extensionRootDir').value;
- var privateKeyPath = $('extensionPrivateKey').value;
- chrome.send('pack', [extensionPath, privateKeyPath, 0]);
- };
- $('browseExtensionDir').addEventListener('click',
- this.handleBrowseExtensionDir_.bind(this));
- $('browsePrivateKey').addEventListener('click',
- this.handleBrowsePrivateKey_.bind(this));
- },
-
- /**
- * Utility function which asks the C++ to show a platform-specific file
- * select dialog, and fire |callback| with the |filePath| that resulted.
- * |selectType| can be either 'file' or 'folder'. |operation| can be 'load',
- * 'packRoot', or 'pem' which are signals to the C++ to do some
- * operation-specific configuration.
- * @private
- */
- showFileDialog_: function(selectType, operation, callback) {
- handleFilePathSelected = function(filePath) {
- callback(filePath);
- handleFilePathSelected = function() {};
- };
-
- chrome.send('extensionSettingsSelectFilePath', [selectType, operation]);
- },
-
- /**
- * Handles the showing of the extension directory browser.
- * @param {Event} e Change event.
- * @private
- */
- handleBrowseExtensionDir_: function(e) {
- this.showFileDialog_('folder', 'load', function(filePath) {
- $('extensionRootDir').value = filePath;
- });
- },
-
- /**
- * Handles the showing of the extension private key file.
- * @param {Event} e Change event.
- * @private
- */
- handleBrowsePrivateKey_: function(e) {
- this.showFileDialog_('file', 'pem', function(filePath) {
- $('extensionPrivateKey').value = filePath;
- });
- },
- };
-
- /**
- * Wrap up the pack process by showing the success |message| and closing
- * the overlay.
- * @param {String} message The message to show to the user.
- */
- PackExtensionOverlay.showSuccessMessage = function(message) {
- OptionsPage.closeOverlay();
- AlertOverlay.show(localStrings.getString('packExtensionOverlay'),
- message, localStrings.getString('ok'), "",
- function() {
- OptionsPage.closeOverlay();
- }, null);
- }
-
- /**
- * Post an alert overlay showing |message|, and upon acknowledgement, close
- * the alert overlay and return to showing the PackExtensionOverlay.
- */
- PackExtensionOverlay.showError = function(message) {
- OptionsPage.closeOverlay();
- AlertOverlay.show(localStrings.getString('packExtensionErrorTitle'),
- message, localStrings.getString('ok'), "",
- function() {
- OptionsPage.closeOverlay();
- OptionsPage.showPageByName('packExtensionOverlay', false);
- }, null);
- }
-
- // Export
- return {
- PackExtensionOverlay: PackExtensionOverlay
- };
-});

Powered by Google App Engine
This is Rietveld 408576698