Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: chrome/browser/browser_about_handler.cc

Issue 9814030: get rid of old options pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixes Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_about_handler.cc
diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc
index 75a1f6c5500d10b3a6edb9cf2796308ddc2486b4..84247a8b2d6eec3a26f9a3e6b76918c0cf371e9e 100644
--- a/chrome/browser/browser_about_handler.cc
+++ b/chrome/browser/browser_about_handler.cc
@@ -103,9 +103,6 @@ bool WillHandleBrowserAboutURL(GURL* url,
if (!url->SchemeIs(chrome::kChromeUIScheme))
return false;
- CommandLine* cl = CommandLine::ForCurrentProcess();
- bool enableUberPage = !cl->HasSwitch(switches::kDisableUberPage);
-
std::string host(url->host());
std::string path;
// Replace about with chrome-urls.
@@ -122,29 +119,20 @@ bool WillHandleBrowserAboutURL(GURL* url,
host = chrome::kChromeUISyncInternalsHost;
// Redirect chrome://extensions.
} else if (host == chrome::kChromeUIExtensionsHost) {
- if (enableUberPage) {
- host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUIExtensionsHost + url->path();
- } else {
- host = chrome::kChromeUISettingsHost;
- path = chrome::kExtensionsSubPage;
- }
+ host = chrome::kChromeUIUberHost;
+ path = chrome::kChromeUIExtensionsHost + url->path();
} else if (host == chrome::kChromeUIHistoryHost) {
- if (enableUberPage) {
- host = chrome::kChromeUIUberHost;
- path = chrome::kChromeUIHistoryHost + url->path();
- } else {
- host = chrome::kChromeUIHistoryFrameHost;
- }
+ host = chrome::kChromeUIUberHost;
+ path = chrome::kChromeUIHistoryHost + url->path();
// Redirect chrome://settings/extensions.
// TODO(csilv): Fix all code paths for this page once Uber page is enabled
// permanently.
- } else if (enableUberPage && host == chrome::kChromeUISettingsHost &&
+ } else if (host == chrome::kChromeUISettingsHost &&
url->path() == std::string("/") + chrome::kExtensionsSubPage) {
host = chrome::kChromeUIUberHost;
path = chrome::kChromeUIExtensionsHost;
// Redirect chrome://settings
- } else if (enableUberPage && host == chrome::kChromeUISettingsHost) {
+ } else if (host == chrome::kChromeUISettingsHost) {
host = chrome::kChromeUIUberHost;
path = chrome::kChromeUISettingsHost + url->path();
}

Powered by Google App Engine
This is Rietveld 408576698