Issue 9722020: Enable snapshots on MIPS. This is based on

Issue 9722020: Enable snapshots on MIPS. This is based on (Closed)

Created:
8 years, 9 months ago by Erik Corry

Modified:
8 years, 9 months ago

Reviewers:
fschneider, Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Enable snapshots on MIPS. This is based on http://codereview.chromium.org/9372063 by Daniel Kalmar. Committed: https://code.google.com/p/v8/source/detail?r=11107

Patch Set 1 #

Total comments: 1

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+206 lines, -119 lines)			Patch
M	SConstruct	View	3 chunks	+13 lines, -2 lines	0 comments	Download
M	src/arm/assembler-arm.h	View	1 chunk	+4 lines, -6 lines	0 comments	Download
M	src/arm/assembler-arm.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/assembler-arm-inl.h	View	2 chunks	+9 lines, -3 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/ia32/assembler-ia32-inl.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/assembler-mips.h	View	2 chunks	+8 lines, -6 lines	0 comments	Download
M	src/mips/assembler-mips.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/assembler-mips-inl.h	View	3 chunks	+23 lines, -5 lines	0 comments	Download
M	src/mips/builtins-mips.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	12 chunks	+33 lines, -26 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mips/ic-mips.cc	View	7 chunks	+18 lines, -15 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	4 chunks	+22 lines, -6 lines	0 comments	Download
M	src/mips/macro-assembler-mips.cc	View	9 chunks	+20 lines, -10 lines	0 comments	Download
M	src/mips/regexp-macro-assembler-mips.cc	View	6 chunks	+6 lines, -6 lines	0 comments	Download
M	src/serialize.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/serialize.cc	View	6 chunks	+37 lines, -12 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/x64/assembler-x64-inl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paul Lind

Erik - Thanks for your reworking of this! It looks good from our side.

8 years, 9 months ago (2012-03-19 17:46:16 UTC) #2

Michael Starzinger

8 years, 9 months ago (2012-03-21 14:07:10 UTC) #3

LGTM.

http://codereview.chromium.org/9722020/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):

http://codereview.chromium.org/9722020/diff/1/test/cctest/cctest.status#newco...
test/cctest/cctest.status:87: [ $arch == mips ]
Since the MIPS section in empty now, let's just remove it.

Expand Messages | Collapse Messages