Issue 9599007: Minor refactoring of window resize code. I wasn't too happy with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9599007: Minor refactoring of window resize code. I wasn't too happy with (Closed)

Created:
8 years, 9 months ago by sky

Modified:
8 years, 9 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, dhollowa+watch_chromium.org, sadrul, ben+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Minor refactoring of window resize code. I wasn't too happy with continuing to have WindowResizer expose logic for WorkspaceWindowResizer. Instead WindowResizer is pure virtual, with some common code in static methods that both implementations can use. This'll make the code for multi-window resizing more centralized. BUG=116079 TEST=refactoring covered by tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124939

Patch Set 1 #

Patch Set 2 : #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+477 lines, -720 lines)			Patch
M	ash/ash.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	ash/wm/default_window_resizer.h	View	1	2 chunks	+24 lines, -93 lines	0 comments	Download
A +	ash/wm/default_window_resizer.cc	View		2 chunks	+31 lines, -307 lines	0 comments	Download
M	ash/wm/toplevel_window_event_filter.cc	View		8 chunks	+27 lines, -12 lines	0 comments	Download
M	ash/wm/window_resizer.h	View	1	3 chunks	+56 lines, -66 lines	0 comments	Download
M	ash/wm/window_resizer.cc	View		8 chunks	+104 lines, -128 lines	0 comments	Download
M	ash/wm/workspace/workspace_event_filter.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.h	View	1	2 chunks	+39 lines, -14 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.cc	View		3 chunks	+111 lines, -54 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer_unittest.cc	View		10 chunks	+81 lines, -44 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/9599007/13

8 years, 9 months ago (2012-03-05 05:42:54 UTC) #3

commit-bot: I haz the power

8 years, 9 months ago (2012-03-05 05:42:59 UTC) #4

Can't apply patch for file ash/wm/default_window_resizer.cc.
While running patch -p0 --forward --force;
patching file ash/wm/default_window_resizer.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 17.
2 out of 2 hunks FAILED -- saving rejects to file
ash/wm/default_window_resizer.cc.rej

Expand Messages | Collapse Messages