Issue 9429066: Coverity: Fix a few pass-by-values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9429066: Coverity: Fix a few pass-by-values. (Closed)

Created:
8 years, 10 months ago by James Hawkins

Modified:
8 years, 9 months ago

Reviewers:
groby-ooo-7-16

CC:
chromium-reviews, jam, mihaip+watch_chromium.org, apatrick_chromium, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Coverity: Fix a few pass-by-values. CID_COUNT=2 CID=103366,103367 TEST=none BUG=none R=groby Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=124883

Patch Set 3 : Revert one. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -13 lines)			Patch
M	chrome/common/extensions/extension_file_util.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/common/extensions/extension_file_util.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/gpu/gpu_data_manager_impl.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/gpu/gpu_data_manager_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/public/browser/gpu_data_manager.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/native_client/src/trusted/plugin/service_runtime.cc	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

groby-ooo-7-16

LGTM if it compiles http://codereview.chromium.org/9429066/diff/1/ppapi/native_client/src/trusted/plugin/service_runtime.cc File ppapi/native_client/src/trusted/plugin/service_runtime.cc (right): http://codereview.chromium.org/9429066/diff/1/ppapi/native_client/src/trusted/plugin/service_runtime.cc#newcode470 ppapi/native_client/src/trusted/plugin/service_runtime.cc:470: const nacl::string& file_id, int64_t offset, ...

8 years, 10 months ago (2012-02-22 21:29:23 UTC) #2

James Hawkins

8 years, 9 months ago (2012-03-04 02:04:29 UTC) #3

http://codereview.chromium.org/9429066/diff/1/ppapi/native_client/src/trusted...
File ppapi/native_client/src/trusted/plugin/service_runtime.cc (right):

http://codereview.chromium.org/9429066/diff/1/ppapi/native_client/src/trusted...
ppapi/native_client/src/trusted/plugin/service_runtime.cc:470: const
nacl::string& file_id, int64_t offset, int64_t bytes_to_write) {
On 2012/02/22 21:29:24, groby wrote:
> Please fix corresponding header

Done.

Expand Messages | Collapse Messages

Issue 9429066: Coverity: Fix a few pass-by-values. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Build fix. #

Patch Set 3 : Revert one. #

Messages