Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: content/browser/gpu/gpu_data_manager_impl.h

Issue 9429066: Coverity: Fix a few pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert one. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_file_util.cc ('k') | content/browser/gpu/gpu_data_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/gpu/gpu_data_manager_impl.h
diff --git a/content/browser/gpu/gpu_data_manager_impl.h b/content/browser/gpu/gpu_data_manager_impl.h
index 40c6b386a08f8b395f864206cc13c520e3cdad6a..32d8301dd7451ad2189ce17c7e78513c1bd4716f 100644
--- a/content/browser/gpu/gpu_data_manager_impl.h
+++ b/content/browser/gpu/gpu_data_manager_impl.h
@@ -26,7 +26,7 @@ class CONTENT_EXPORT GpuDataManagerImpl
// Getter for the singleton. This will return NULL on failure.
static GpuDataManagerImpl* GetInstance();
- // GpuDataManager implementation:
+ // GpuDataManager implementation.
virtual content::GpuFeatureType GetGpuFeatureType() OVERRIDE;
virtual void SetGpuFeatureType(content::GpuFeatureType feature_type) OVERRIDE;
virtual content::GPUInfo GetGPUInfo() const OVERRIDE;
@@ -34,7 +34,7 @@ class CONTENT_EXPORT GpuDataManagerImpl
virtual void RequestCompleteGpuInfoIfNeeded() OVERRIDE;
virtual bool IsCompleteGPUInfoAvailable() const OVERRIDE;
virtual bool ShouldUseSoftwareRendering() OVERRIDE;
- virtual void RegisterSwiftShaderPath(FilePath path) OVERRIDE;
+ virtual void RegisterSwiftShaderPath(const FilePath& path) OVERRIDE;
virtual const base::ListValue& GetLogMessages() const OVERRIDE;
virtual void AddObserver(content::GpuDataManagerObserver* observer) OVERRIDE;
virtual void RemoveObserver(
@@ -46,7 +46,7 @@ class CONTENT_EXPORT GpuDataManagerImpl
void AddLogMessage(Value* msg);
// Inserting disable-feature switches into renderer process command-line
- // in correspondance to preliminary gpu feature flags.
+ // in correspondence to preliminary gpu feature flags.
void AppendRendererCommandLine(CommandLine* command_line);
// Inserting switches into gpu process command-line: kUseGL,
« no previous file with comments | « chrome/common/extensions/extension_file_util.cc ('k') | content/browser/gpu/gpu_data_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698