Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2537)

Unified Diff: chrome/common/extensions/extension_file_util.h

Issue 9429066: Coverity: Fix a few pass-by-values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert one. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/extension_file_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_file_util.h
diff --git a/chrome/common/extensions/extension_file_util.h b/chrome/common/extensions/extension_file_util.h
index 9cffdda5aae8828721201718ef07b36c17379db6..1ab3f07678dbcdb6878df314410ee1d26e1a4a5e 100644
--- a/chrome/common/extensions/extension_file_util.h
+++ b/chrome/common/extensions/extension_file_util.h
@@ -20,7 +20,7 @@ namespace base {
class DictionaryValue;
}
-// Utilties for manipulating the on-disk storage of extensions.
+// Utilities for manipulating the on-disk storage of extensions.
namespace extension_file_util {
// The name of the directory inside the profile that we store installed
@@ -28,7 +28,7 @@ namespace extension_file_util {
extern const char kInstallDirectoryName[];
// Copies |unpacked_source_dir| into the right location under |extensions_dir|.
-// The destination directiory is returned on success, or empty path is returned
+// The destination directory is returned on success, or empty path is returned
// on failure.
FilePath InstallExtension(const FilePath& unpacked_source_dir,
const std::string& id,
@@ -48,7 +48,7 @@ scoped_refptr<Extension> LoadExtension(const FilePath& extension_root,
// The same as LoadExtension except use the provided |extension_id|.
scoped_refptr<Extension> LoadExtension(const FilePath& extension_root,
- std::string extension_id,
+ const std::string& extension_id,
Extension::Location location,
int flags,
std::string* error);
« no previous file with comments | « no previous file | chrome/common/extensions/extension_file_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698