Issue 9424033: Removed Runtime_DefineAccessor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9424033: Removed Runtime_DefineAccessor. (Closed)

Created:
8 years, 10 months ago by Sven Panne

Modified:
8 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Removed Runtime_DefineAccessor. Runtime_DefineOrRedfineAccessorProperty basically does the same, so we have 1 code path less to worry about. Committed: https://code.google.com/p/v8/source/detail?r=10779

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporated review comments. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -74 lines)			Patch
M	src/arm/full-codegen-arm.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/regexp.js	View	1	2 chunks	+57 lines, -45 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+0 lines, -24 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a nit). https://chromiumcodereview.appspot.com/9424033/diff/1/src/regexp.js File src/regexp.js (right): https://chromiumcodereview.appspot.com/9424033/diff/1/src/regexp.js#newcode471 src/regexp.js:471: %DefineOrRedefineAccessorProperty($RegExp, 'lastParen', GETTER, Should fit ...

8 years, 10 months ago (2012-02-21 12:14:28 UTC) #2

Sven Panne

8 years, 10 months ago (2012-02-21 12:23:31 UTC) #3

http://codereview.chromium.org/9424033/diff/1/src/regexp.js
File src/regexp.js (right):

http://codereview.chromium.org/9424033/diff/1/src/regexp.js#newcode471
src/regexp.js:471: %DefineOrRedefineAccessorProperty($RegExp, 'lastParen',
GETTER,
On 2012/02/21 12:14:28, Michael Starzinger wrote:
> Should fit into two lines.

Done.

Expand Messages | Collapse Messages