Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Side by Side Diff: src/ia32/full-codegen-ia32.cc

Issue 9424033: Removed Runtime_DefineAccessor. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorporated review comments. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1479 matching lines...) Expand 10 before | Expand all | Expand 10 after
1490 } 1490 }
1491 break; 1491 break;
1492 case ObjectLiteral::Property::SETTER: 1492 case ObjectLiteral::Property::SETTER:
1493 case ObjectLiteral::Property::GETTER: 1493 case ObjectLiteral::Property::GETTER:
1494 __ push(Operand(esp, 0)); // Duplicate receiver. 1494 __ push(Operand(esp, 0)); // Duplicate receiver.
1495 VisitForStackValue(key); 1495 VisitForStackValue(key);
1496 __ push(Immediate(property->kind() == ObjectLiteral::Property::SETTER ? 1496 __ push(Immediate(property->kind() == ObjectLiteral::Property::SETTER ?
1497 Smi::FromInt(1) : 1497 Smi::FromInt(1) :
1498 Smi::FromInt(0))); 1498 Smi::FromInt(0)));
1499 VisitForStackValue(value); 1499 VisitForStackValue(value);
1500 __ CallRuntime(Runtime::kDefineAccessor, 4); 1500 __ push(Immediate(Smi::FromInt(NONE)));
1501 __ CallRuntime(Runtime::kDefineOrRedefineAccessorProperty, 5);
1501 break; 1502 break;
1502 default: UNREACHABLE(); 1503 default: UNREACHABLE();
1503 } 1504 }
1504 } 1505 }
1505 1506
1506 if (expr->has_function()) { 1507 if (expr->has_function()) {
1507 ASSERT(result_saved); 1508 ASSERT(result_saved);
1508 __ push(Operand(esp, 0)); 1509 __ push(Operand(esp, 0));
1509 __ CallRuntime(Runtime::kToFastProperties, 1); 1510 __ CallRuntime(Runtime::kToFastProperties, 1);
1510 } 1511 }
(...skipping 2925 matching lines...) Expand 10 before | Expand all | Expand 10 after
4436 *context_length = 0; 4437 *context_length = 0;
4437 return previous_; 4438 return previous_;
4438 } 4439 }
4439 4440
4440 4441
4441 #undef __ 4442 #undef __
4442 4443
4443 } } // namespace v8::internal 4444 } } // namespace v8::internal
4444 4445
4445 #endif // V8_TARGET_ARCH_IA32 4446 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/full-codegen-arm.cc ('k') | src/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698