Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 9424033: Removed Runtime_DefineAccessor. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorporated review comments. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1464 matching lines...) Expand 10 before | Expand all | Expand 10 after
1475 } 1475 }
1476 break; 1476 break;
1477 case ObjectLiteral::Property::SETTER: 1477 case ObjectLiteral::Property::SETTER:
1478 case ObjectLiteral::Property::GETTER: 1478 case ObjectLiteral::Property::GETTER:
1479 __ push(Operand(rsp, 0)); // Duplicate receiver. 1479 __ push(Operand(rsp, 0)); // Duplicate receiver.
1480 VisitForStackValue(key); 1480 VisitForStackValue(key);
1481 __ Push(property->kind() == ObjectLiteral::Property::SETTER ? 1481 __ Push(property->kind() == ObjectLiteral::Property::SETTER ?
1482 Smi::FromInt(1) : 1482 Smi::FromInt(1) :
1483 Smi::FromInt(0)); 1483 Smi::FromInt(0));
1484 VisitForStackValue(value); 1484 VisitForStackValue(value);
1485 __ CallRuntime(Runtime::kDefineAccessor, 4); 1485 __ Push(Smi::FromInt(NONE));
1486 __ CallRuntime(Runtime::kDefineOrRedefineAccessorProperty, 5);
1486 break; 1487 break;
1487 } 1488 }
1488 } 1489 }
1489 1490
1490 if (expr->has_function()) { 1491 if (expr->has_function()) {
1491 ASSERT(result_saved); 1492 ASSERT(result_saved);
1492 __ push(Operand(rsp, 0)); 1493 __ push(Operand(rsp, 0));
1493 __ CallRuntime(Runtime::kToFastProperties, 1); 1494 __ CallRuntime(Runtime::kToFastProperties, 1);
1494 } 1495 }
1495 1496
(...skipping 2885 matching lines...) Expand 10 before | Expand all | Expand 10 after
4381 *context_length = 0; 4382 *context_length = 0;
4382 return previous_; 4383 return previous_;
4383 } 4384 }
4384 4385
4385 4386
4386 #undef __ 4387 #undef __
4387 4388
4388 } } // namespace v8::internal 4389 } } // namespace v8::internal
4389 4390
4390 #endif // V8_TARGET_ARCH_X64 4391 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/runtime.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698