Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/mips/full-codegen-mips.cc

Issue 9424033: Removed Runtime_DefineAccessor. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Incorporated review comments. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/regexp.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1514 matching lines...) Expand 10 before | Expand all | Expand 10 after
1525 case ObjectLiteral::Property::SETTER: 1525 case ObjectLiteral::Property::SETTER:
1526 // Duplicate receiver on stack. 1526 // Duplicate receiver on stack.
1527 __ lw(a0, MemOperand(sp)); 1527 __ lw(a0, MemOperand(sp));
1528 __ push(a0); 1528 __ push(a0);
1529 VisitForStackValue(key); 1529 VisitForStackValue(key);
1530 __ li(a1, Operand(property->kind() == ObjectLiteral::Property::SETTER ? 1530 __ li(a1, Operand(property->kind() == ObjectLiteral::Property::SETTER ?
1531 Smi::FromInt(1) : 1531 Smi::FromInt(1) :
1532 Smi::FromInt(0))); 1532 Smi::FromInt(0)));
1533 __ push(a1); 1533 __ push(a1);
1534 VisitForStackValue(value); 1534 VisitForStackValue(value);
1535 __ CallRuntime(Runtime::kDefineAccessor, 4); 1535 __ li(a0, Operand(Smi::FromInt(NONE)));
1536 __ push(a0);
1537 __ CallRuntime(Runtime::kDefineOrRedefineAccessorProperty, 5);
1536 break; 1538 break;
1537 } 1539 }
1538 } 1540 }
1539 1541
1540 if (expr->has_function()) { 1542 if (expr->has_function()) {
1541 ASSERT(result_saved); 1543 ASSERT(result_saved);
1542 __ lw(a0, MemOperand(sp)); 1544 __ lw(a0, MemOperand(sp));
1543 __ push(a0); 1545 __ push(a0);
1544 __ CallRuntime(Runtime::kToFastProperties, 1); 1546 __ CallRuntime(Runtime::kToFastProperties, 1);
1545 } 1547 }
(...skipping 2909 matching lines...) Expand 10 before | Expand all | Expand 10 after
4455 *context_length = 0; 4457 *context_length = 0;
4456 return previous_; 4458 return previous_;
4457 } 4459 }
4458 4460
4459 4461
4460 #undef __ 4462 #undef __
4461 4463
4462 } } // namespace v8::internal 4464 } } // namespace v8::internal
4463 4465
4464 #endif // V8_TARGET_ARCH_MIPS 4466 #endif // V8_TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « src/ia32/full-codegen-ia32.cc ('k') | src/regexp.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698