Issue 9389005: DescriptorArray::CopyFrom should always drop transitions for CALLBACKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9389005: DescriptorArray::CopyFrom should always drop transitions for CALLBACKS. (Closed)

Created:
8 years, 10 months ago by Sven Panne

Modified:
8 years, 10 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

DescriptorArray::CopyFrom should always drop transitions for CALLBACKS. Committed: https://code.google.com/p/v8/source/detail?r=10685

Patch Set 2 : Improved comment. #

Total comments: 2

Patch Set 3 : Improved comments. #

Created: 8 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -20 lines)			Patch
M	src/bootstrapper.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/factory.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/objects.h	View	1 2	2 chunks	+15 lines, -5 lines	0 comments	Download
M	src/objects.cc	View		4 chunks	+45 lines, -2 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with a nit). https://chromiumcodereview.appspot.com/9389005/diff/2001/src/objects.h File src/objects.h (right): https://chromiumcodereview.appspot.com/9389005/diff/2001/src/objects.h#newcode2445 src/objects.h:2445: MUST_USE_RESULT MaybeObject* CopyFrom(int dst_index, Could ...

8 years, 10 months ago (2012-02-13 14:04:17 UTC) #2