Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: src/objects-inl.h

Issue 9389005: DescriptorArray::CopyFrom should always drop transitions for CALLBACKS. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Improved comments. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2035 matching lines...) Expand 10 before | Expand all | Expand 10 after
2046 FixedArray* content_array = GetContentArray(); 2046 FixedArray* content_array = GetContentArray();
2047 NoIncrementalWriteBarrierSet(content_array, 2047 NoIncrementalWriteBarrierSet(content_array,
2048 ToValueIndex(descriptor_number), 2048 ToValueIndex(descriptor_number),
2049 desc->GetValue()); 2049 desc->GetValue());
2050 NoIncrementalWriteBarrierSet(content_array, 2050 NoIncrementalWriteBarrierSet(content_array,
2051 ToDetailsIndex(descriptor_number), 2051 ToDetailsIndex(descriptor_number),
2052 desc->GetDetails().AsSmi()); 2052 desc->GetDetails().AsSmi());
2053 } 2053 }
2054 2054
2055 2055
2056 void DescriptorArray::CopyFrom(int index,
2057 DescriptorArray* src,
2058 int src_index,
2059 const WhitenessWitness& witness) {
2060 Descriptor desc;
2061 src->Get(src_index, &desc);
2062 Set(index, &desc, witness);
2063 }
2064
2065
2066 void DescriptorArray::NoIncrementalWriteBarrierSwapDescriptors( 2056 void DescriptorArray::NoIncrementalWriteBarrierSwapDescriptors(
2067 int first, int second) { 2057 int first, int second) {
2068 NoIncrementalWriteBarrierSwap(this, ToKeyIndex(first), ToKeyIndex(second)); 2058 NoIncrementalWriteBarrierSwap(this, ToKeyIndex(first), ToKeyIndex(second));
2069 FixedArray* content_array = GetContentArray(); 2059 FixedArray* content_array = GetContentArray();
2070 NoIncrementalWriteBarrierSwap(content_array, 2060 NoIncrementalWriteBarrierSwap(content_array,
2071 ToValueIndex(first), 2061 ToValueIndex(first),
2072 ToValueIndex(second)); 2062 ToValueIndex(second));
2073 NoIncrementalWriteBarrierSwap(content_array, 2063 NoIncrementalWriteBarrierSwap(content_array,
2074 ToDetailsIndex(first), 2064 ToDetailsIndex(first),
2075 ToDetailsIndex(second)); 2065 ToDetailsIndex(second));
(...skipping 2829 matching lines...) Expand 10 before | Expand all | Expand 10 after
4905 #undef WRITE_INT_FIELD 4895 #undef WRITE_INT_FIELD
4906 #undef READ_SHORT_FIELD 4896 #undef READ_SHORT_FIELD
4907 #undef WRITE_SHORT_FIELD 4897 #undef WRITE_SHORT_FIELD
4908 #undef READ_BYTE_FIELD 4898 #undef READ_BYTE_FIELD
4909 #undef WRITE_BYTE_FIELD 4899 #undef WRITE_BYTE_FIELD
4910 4900
4911 4901
4912 } } // namespace v8::internal 4902 } } // namespace v8::internal
4913 4903
4914 #endif // V8_OBJECTS_INL_H_ 4904 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698