src/bootstrapper.cc - Issue 9389005: DescriptorArray::CopyFrom should always drop transitions for CALLBACKS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 9389005: DescriptorArray::CopyFrom should always drop transitions for CALLBACKS. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Improved comments. Created 8 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 31a771fbeb0a00f10b265ca0ddaa7227a105a361..ef53df46cd17141937fc916539b5a70cee08d04c 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -1743,7 +1743,9 @@ bool Genesis::InstallNatives() {

Handle<DescriptorArray> array_descriptors(

array_function->initial_map()->instance_descriptors());

int index = array_descriptors->SearchWithCache(heap()->length_symbol());

- reresult_descriptors->CopyFrom(0, *array_descriptors, index, witness);

+ MaybeObject* copy_result =

+ reresult_descriptors->CopyFrom(0, *array_descriptors, index, witness);

+ if (copy_result->IsFailure()) return false;

int enum_index = 0;

{

« no previous file with comments | « no previous file | src/factory.cc » ('j') | no next file with comments »