Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: src/bootstrapper.cc

Issue 9389005: DescriptorArray::CopyFrom should always drop transitions for CALLBACKS. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Improved comments. Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1725 matching lines...) Expand 10 before | Expand all | Expand 10 after
1736 1736
1737 // Update map with length accessor from Array and add "index" and "input". 1737 // Update map with length accessor from Array and add "index" and "input".
1738 Handle<DescriptorArray> reresult_descriptors = 1738 Handle<DescriptorArray> reresult_descriptors =
1739 factory()->NewDescriptorArray(3); 1739 factory()->NewDescriptorArray(3);
1740 DescriptorArray::WhitenessWitness witness(*reresult_descriptors); 1740 DescriptorArray::WhitenessWitness witness(*reresult_descriptors);
1741 1741
1742 JSFunction* array_function = global_context()->array_function(); 1742 JSFunction* array_function = global_context()->array_function();
1743 Handle<DescriptorArray> array_descriptors( 1743 Handle<DescriptorArray> array_descriptors(
1744 array_function->initial_map()->instance_descriptors()); 1744 array_function->initial_map()->instance_descriptors());
1745 int index = array_descriptors->SearchWithCache(heap()->length_symbol()); 1745 int index = array_descriptors->SearchWithCache(heap()->length_symbol());
1746 reresult_descriptors->CopyFrom(0, *array_descriptors, index, witness); 1746 MaybeObject* copy_result =
1747 reresult_descriptors->CopyFrom(0, *array_descriptors, index, witness);
1748 if (copy_result->IsFailure()) return false;
1747 1749
1748 int enum_index = 0; 1750 int enum_index = 0;
1749 { 1751 {
1750 FieldDescriptor index_field(heap()->index_symbol(), 1752 FieldDescriptor index_field(heap()->index_symbol(),
1751 JSRegExpResult::kIndexIndex, 1753 JSRegExpResult::kIndexIndex,
1752 NONE, 1754 NONE,
1753 enum_index++); 1755 enum_index++);
1754 reresult_descriptors->Set(1, &index_field, witness); 1756 reresult_descriptors->Set(1, &index_field, witness);
1755 } 1757 }
1756 1758
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
2362 return from + sizeof(NestingCounterType); 2364 return from + sizeof(NestingCounterType);
2363 } 2365 }
2364 2366
2365 2367
2366 // Called when the top-level V8 mutex is destroyed. 2368 // Called when the top-level V8 mutex is destroyed.
2367 void Bootstrapper::FreeThreadResources() { 2369 void Bootstrapper::FreeThreadResources() {
2368 ASSERT(!IsActive()); 2370 ASSERT(!IsActive());
2369 } 2371 }
2370 2372
2371 } } // namespace v8::internal 2373 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698