Issue 9284033: net: Give more descriptive names for code around the request merging logic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9284033: net: Give more descriptive names for code around the request merging logic. (Closed)

Created:
8 years, 11 months ago by satorux1

Modified:
8 years, 11 months ago

Reviewers:
wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net: Give more descriptive names for code around the request merging logic. This is a follow-up patch based on wtc's comments on the earlier patch: http://codereview.chromium.org/9270030/ BUG=72001 TEST=no logic change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118942

Patch Set 1 #

Total comments: 1

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -21 lines)			Patch
M	net/base/upload_data.cc	View	1 chunk	+5 lines, -1 line	1 comment	Download
M	net/http/http_stream_parser.h	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	net/http/http_stream_parser.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	net/http/http_stream_parser_unittest.cc	View	5 chunks	+18 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wtc

LGTM. http://codereview.chromium.org/9284033/diff/1/net/base/upload_data.cc File net/base/upload_data.cc (right): http://codereview.chromium.org/9284033/diff/1/net/base/upload_data.cc#newcode185 net/base/upload_data.cc:185: // first chunk is not yet delivered. Thank ...

8 years, 11 months ago (2012-01-24 20:10:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/9284033/1

8 years, 11 months ago (2012-01-24 21:33:29 UTC) #3

Change committed as 118942

Expand Messages | Collapse Messages