Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: net/base/upload_data.cc

Issue 9284033: net: Give more descriptive names for code around the request merging logic. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_stream_parser.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/upload_data.cc
diff --git a/net/base/upload_data.cc b/net/base/upload_data.cc
index 019254e48878c431c31304373c0ef5a9bd5041e7..01eaacacc4eee4248e67900f4e6a9793149c96ed 100644
--- a/net/base/upload_data.cc
+++ b/net/base/upload_data.cc
@@ -178,7 +178,11 @@ uint64 UploadData::GetContentLength() {
}
bool UploadData::IsInMemory() const {
- // Chunks are provided as a stream, hence it's not in memory.
+ // Chunks are in memory, but UploadData does not have all the chunks at
+ // once. Chunks are provided progressively with AppendChunk() as chunks
+ // are ready. Check is_chunked_ here, rather than relying on the loop
+ // below, as there is a case that is_chunked_ is set to true, but the
+ // first chunk is not yet delivered.
wtc 2012/01/24 20:10:57 Thank you for explaining this to me.
if (is_chunked_)
return false;
« no previous file with comments | « no previous file | net/http/http_stream_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698