net: Give more descriptive names for code around the request merging logic.

net/base/upload_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/upload_data.h"
 
 #include <algorithm>
 
 #include "base/file_util.h"
 #include "base/logging.h"
@@ skipping 160 matching lines @@
     return 0;
 
   uint64 len = 0;
   std::vector<Element>::iterator it = elements_.begin();
   for (; it != elements_.end(); ++it)
     len += (*it).GetContentLength();
   return len;
 }
 
 bool UploadData::IsInMemory() const {
-  // Chunks are provided as a stream, hence it's not in memory.
+  // Chunks are in memory, but UploadData does not have all the chunks at
+  // once. Chunks are provided progressively with AppendChunk() as chunks
+  // are ready. Check is_chunked_ here, rather than relying on the loop
+  // below, as there is a case that is_chunked_ is set to true, but the
+  // first chunk is not yet delivered.

[wtc, 2012/01/24 20:10:57]

Thank you for explaining this to me.

   if (is_chunked_)
     return false;
 
   for (size_t i = 0; i < elements_.size(); ++i) {
     if (elements_[i].type() != TYPE_BYTES)
       return false;
   }
   return true;
 }
 
 void UploadData::SetElements(const std::vector<Element>& elements) {
   elements_ = elements;
 }
 
 UploadData::~UploadData() {
 }
 
 }  // namespace net