Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 9169088: Use cmp instead of tst to check for zero. (Closed)

Created:
8 years, 11 months ago by Yang
Modified:
8 years, 11 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Use cmp instead of tst to check for zero. Committed: https://code.google.com/p/v8/source/detail?r=10516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/code-stubs-arm.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Yang
PTAL. As suggested by the ARM folks.
8 years, 11 months ago (2012-01-26 15:24:48 UTC) #1
ulan
8 years, 11 months ago (2012-01-26 15:29:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698