src/arm/builtins-arm.cc - Issue 9169088: Use cmp instead of tst to check for zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/builtins-arm.cc

Issue 9169088: Use cmp instead of tst to check for zero. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/builtins-arm.cc

diff --git a/src/arm/builtins-arm.cc b/src/arm/builtins-arm.cc

index b461b45a57384d1c81c2a0013503e253a323bc5b..6aa02ac308ffb49d3d3840cfd8b40ee52cddf35a 100644

--- a/src/arm/builtins-arm.cc

+++ b/src/arm/builtins-arm.cc

@@ -1297,7 +1297,7 @@ void Builtins::Generate_FunctionCall(MacroAssembler* masm) {

// 1. Make sure we have at least one argument.

// r0: actual number of arguments

{ Label done;

- __ tst(r0, Operand(r0));

+ __ cmp(r0, Operand(0));

__ b(ne, &done);

__ LoadRoot(r2, Heap::kUndefinedValueRootIndex);

__ push(r2);

« no previous file with comments | « no previous file | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »