Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 9169088: Use cmp instead of tst to check for zero. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/regexp-macro-assembler-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1802 matching lines...) Expand 10 before | Expand all | Expand 10 after
1813 __ sub(scratch1, left, Operand(right), SetCC); 1813 __ sub(scratch1, left, Operand(right), SetCC);
1814 __ b(vs, &stub_call); 1814 __ b(vs, &stub_call);
1815 __ mov(right, scratch1); 1815 __ mov(right, scratch1);
1816 break; 1816 break;
1817 case Token::MUL: { 1817 case Token::MUL: {
1818 __ SmiUntag(ip, right); 1818 __ SmiUntag(ip, right);
1819 __ smull(scratch1, scratch2, left, ip); 1819 __ smull(scratch1, scratch2, left, ip);
1820 __ mov(ip, Operand(scratch1, ASR, 31)); 1820 __ mov(ip, Operand(scratch1, ASR, 31));
1821 __ cmp(ip, Operand(scratch2)); 1821 __ cmp(ip, Operand(scratch2));
1822 __ b(ne, &stub_call); 1822 __ b(ne, &stub_call);
1823 __ tst(scratch1, Operand(scratch1)); 1823 __ cmp(scratch1, Operand(0));
1824 __ mov(right, Operand(scratch1), LeaveCC, ne); 1824 __ mov(right, Operand(scratch1), LeaveCC, ne);
1825 __ b(ne, &done); 1825 __ b(ne, &done);
1826 __ add(scratch2, right, Operand(left), SetCC); 1826 __ add(scratch2, right, Operand(left), SetCC);
1827 __ mov(right, Operand(Smi::FromInt(0)), LeaveCC, pl); 1827 __ mov(right, Operand(Smi::FromInt(0)), LeaveCC, pl);
1828 __ b(mi, &stub_call); 1828 __ b(mi, &stub_call);
1829 break; 1829 break;
1830 } 1830 }
1831 case Token::BIT_OR: 1831 case Token::BIT_OR:
1832 __ orr(right, left, Operand(right)); 1832 __ orr(right, left, Operand(right));
1833 break; 1833 break;
(...skipping 2556 matching lines...) Expand 10 before | Expand all | Expand 10 after
4390 *context_length = 0; 4390 *context_length = 0;
4391 return previous_; 4391 return previous_;
4392 } 4392 }
4393 4393
4394 4394
4395 #undef __ 4395 #undef __
4396 4396
4397 } } // namespace v8::internal 4397 } } // namespace v8::internal
4398 4398
4399 #endif // V8_TARGET_ARCH_ARM 4399 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/regexp-macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698