src/arm/full-codegen-arm.cc - Issue 9169088: Use cmp instead of tst to check for zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/full-codegen-arm.cc

Issue 9169088: Use cmp instead of tst to check for zero. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/full-codegen-arm.cc

diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc

index 6654263989e82501ff86d2f1096061d4de82dd68..256e1616c8bacccab1817792a49ddc4ccab1b2fb 100644

--- a/src/arm/full-codegen-arm.cc

+++ b/src/arm/full-codegen-arm.cc

@@ -1820,7 +1820,7 @@ void FullCodeGenerator::EmitInlineSmiBinaryOp(BinaryOperation* expr,

__ mov(ip, Operand(scratch1, ASR, 31));

__ cmp(ip, Operand(scratch2));

__ b(ne, &stub_call);

- __ tst(scratch1, Operand(scratch1));

+ __ cmp(scratch1, Operand(0));

__ mov(right, Operand(scratch1), LeaveCC, ne);

__ b(ne, &done);

__ add(scratch2, right, Operand(left), SetCC);

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/regexp-macro-assembler-arm.cc » ('j') | no next file with comments »