Issue 9150025: MIPS: Fix for an ARM register allocation bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9150025: MIPS: Fix for an ARM register allocation bug. (Closed)

Created:
8 years, 11 months ago by kalmard

Modified:
8 years, 11 months ago

Reviewers:
kisg, Paul Lind, Kevin Millikin (Chromium), danno

CC:
v8-dev

Visibility:
Public.

More Reviews

Description

MIPS: Fix for an ARM register allocation bug. Port r10374 (03bbe39). Note: the MIPS version was not affected by the bug. This is merely a style cleanup. Original commit message: An off-by-one in the register allocator could lead to allocating (and clobbering) the reserved 0.0 double register. This required a function with 14 or more live double values. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=10440

Patch Set 1 #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -30 lines)			Patch
M	src/mips/assembler-mips.h	View	3 chunks	+10 lines, -7 lines	0 comments	Download
M	src/mips/assembler-mips-inl.h	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	src/mips/lithium-gap-resolver-mips.cc	View	7 chunks	+11 lines, -12 lines	0 comments	Download
M	src/mips/macro-assembler-mips.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kalmard

Successful testing of v8 on MIPS requires the following patches to be landed as well: ...

8 years, 11 months ago (2012-01-19 12:35:52 UTC) #1

LGTM, I will land it.

Expand Messages | Collapse Messages