Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 830833002: Makes GetComponentExtensionResourceManager() thread-safe. (Closed)

Created:
5 years, 11 months ago by Jun Mukai
Modified:
5 years, 11 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Makes GetComponentExtensionResourceManager() thread-safe. As is noted in a bug, this method can be called on various thread. Actually, the instance itself holds simple mapping and its method can be const, therefore it's safer to early-initialize and the method just returns the already initialized object. Also this should be const and the method does not change its internal state, therefore it's thread safe. BUG=445747 R=yoz@chromium.org TEST=no functional changes / build succeeds Committed: https://crrev.com/ee458c9161f034acde693bc6823d18b6845472c3 Cr-Commit-Position: refs/heads/master@{#310029}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -23 lines) Patch
M chrome/browser/extensions/chrome_component_extension_resource_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_component_extension_resource_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_component_extension_resource_manager_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/chrome_extensions_browser_client.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M extensions/browser/api/execute_code_function.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M extensions/browser/component_extension_resource_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/extensions_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/image_loader.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/test_extensions_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_extensions_browser_client.h View 1 chunk +2 lines, -2 lines 2 comments Download
M extensions/shell/browser/shell_extensions_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Jun Mukai
5 years, 11 months ago (2015-01-01 07:13:49 UTC) #1
Jun Mukai
yoz, are you back? Could you take a look?
5 years, 11 months ago (2015-01-05 23:10:50 UTC) #2
Yoyo Zhou
LGTM https://chromiumcodereview.appspot.com/830833002/diff/20001/extensions/shell/browser/shell_extensions_browser_client.h File extensions/shell/browser/shell_extensions_browser_client.h (right): https://chromiumcodereview.appspot.com/830833002/diff/20001/extensions/shell/browser/shell_extensions_browser_client.h#newcode75 extensions/shell/browser/shell_extensions_browser_client.h:75: GetComponentExtensionResourceManager() override; nit: this looks odd, is it ...
5 years, 11 months ago (2015-01-06 00:50:46 UTC) #3
Jun Mukai
https://chromiumcodereview.appspot.com/830833002/diff/20001/extensions/shell/browser/shell_extensions_browser_client.h File extensions/shell/browser/shell_extensions_browser_client.h (right): https://chromiumcodereview.appspot.com/830833002/diff/20001/extensions/shell/browser/shell_extensions_browser_client.h#newcode75 extensions/shell/browser/shell_extensions_browser_client.h:75: GetComponentExtensionResourceManager() override; On 2015/01/06 00:50:46, Yoyo Zhou wrote: > ...
5 years, 11 months ago (2015-01-06 01:16:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/830833002/20001
5 years, 11 months ago (2015-01-06 01:18:13 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-06 01:31:02 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 01:31:58 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee458c9161f034acde693bc6823d18b6845472c3
Cr-Commit-Position: refs/heads/master@{#310029}

Powered by Google App Engine
This is Rietveld 408576698