Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Side by Side Diff: extensions/shell/browser/shell_extensions_browser_client.h

Issue 830833002: Makes GetComponentExtensionResourceManager() thread-safe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_SHELL_BROWSER_SHELL_EXTENSIONS_BROWSER_CLIENT_H_ 5 #ifndef EXTENSIONS_SHELL_BROWSER_SHELL_EXTENSIONS_BROWSER_CLIENT_H_
6 #define EXTENSIONS_SHELL_BROWSER_SHELL_EXTENSIONS_BROWSER_CLIENT_H_ 6 #define EXTENSIONS_SHELL_BROWSER_SHELL_EXTENSIONS_BROWSER_CLIENT_H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "extensions/browser/extensions_browser_client.h" 9 #include "extensions/browser/extensions_browser_client.h"
10 10
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 void PermitExternalProtocolHandler() override; 64 void PermitExternalProtocolHandler() override;
65 scoped_ptr<AppSorting> CreateAppSorting() override; 65 scoped_ptr<AppSorting> CreateAppSorting() override;
66 bool IsRunningInForcedAppMode() override; 66 bool IsRunningInForcedAppMode() override;
67 ApiActivityMonitor* GetApiActivityMonitor( 67 ApiActivityMonitor* GetApiActivityMonitor(
68 content::BrowserContext* context) override; 68 content::BrowserContext* context) override;
69 ExtensionSystemProvider* GetExtensionSystemFactory() override; 69 ExtensionSystemProvider* GetExtensionSystemFactory() override;
70 void RegisterExtensionFunctions( 70 void RegisterExtensionFunctions(
71 ExtensionFunctionRegistry* registry) const override; 71 ExtensionFunctionRegistry* registry) const override;
72 scoped_ptr<RuntimeAPIDelegate> CreateRuntimeAPIDelegate( 72 scoped_ptr<RuntimeAPIDelegate> CreateRuntimeAPIDelegate(
73 content::BrowserContext* context) const override; 73 content::BrowserContext* context) const override;
74 ComponentExtensionResourceManager* GetComponentExtensionResourceManager() 74 const ComponentExtensionResourceManager*
75 override; 75 GetComponentExtensionResourceManager() override;
Yoyo Zhou 2015/01/06 00:50:46 nit: this looks odd, is it clang-formatted correct
Jun Mukai 2015/01/06 01:16:50 This is the output of clang-format actually. with
76 void BroadcastEventToRenderers(const std::string& event_name, 76 void BroadcastEventToRenderers(const std::string& event_name,
77 scoped_ptr<base::ListValue> args) override; 77 scoped_ptr<base::ListValue> args) override;
78 net::NetLog* GetNetLog() override; 78 net::NetLog* GetNetLog() override;
79 ExtensionCache* GetExtensionCache() override; 79 ExtensionCache* GetExtensionCache() override;
80 bool IsBackgroundUpdateAllowed() override; 80 bool IsBackgroundUpdateAllowed() override;
81 bool IsMinBrowserVersionSupported(const std::string& min_version) override; 81 bool IsMinBrowserVersionSupported(const std::string& min_version) override;
82 82
83 // Sets the API client. 83 // Sets the API client.
84 void SetAPIClientForTest(ExtensionsAPIClient* api_client); 84 void SetAPIClientForTest(ExtensionsAPIClient* api_client);
85 85
86 private: 86 private:
87 // The single BrowserContext for app_shell. Not owned. 87 // The single BrowserContext for app_shell. Not owned.
88 content::BrowserContext* browser_context_; 88 content::BrowserContext* browser_context_;
89 89
90 // The PrefService for |browser_context_|. Not owned. 90 // The PrefService for |browser_context_|. Not owned.
91 PrefService* pref_service_; 91 PrefService* pref_service_;
92 92
93 // Support for extension APIs. 93 // Support for extension APIs.
94 scoped_ptr<ExtensionsAPIClient> api_client_; 94 scoped_ptr<ExtensionsAPIClient> api_client_;
95 95
96 // The extension cache used for download and installation. 96 // The extension cache used for download and installation.
97 scoped_ptr<ExtensionCache> extension_cache_; 97 scoped_ptr<ExtensionCache> extension_cache_;
98 98
99 DISALLOW_COPY_AND_ASSIGN(ShellExtensionsBrowserClient); 99 DISALLOW_COPY_AND_ASSIGN(ShellExtensionsBrowserClient);
100 }; 100 };
101 101
102 } // namespace extensions 102 } // namespace extensions
103 103
104 #endif // EXTENSIONS_SHELL_BROWSER_SHELL_EXTENSIONS_BROWSER_CLIENT_H_ 104 #endif // EXTENSIONS_SHELL_BROWSER_SHELL_EXTENSIONS_BROWSER_CLIENT_H_
OLDNEW
« no previous file with comments | « extensions/browser/test_extensions_browser_client.cc ('k') | extensions/shell/browser/shell_extensions_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698