extensions/shell/browser/shell_extensions_browser_client.h - Issue 830833002: Makes GetComponentExtensionResourceManager() thread-safe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_extensions_browser_client.h

Issue 830833002: Makes GetComponentExtensionResourceManager() thread-safe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/test_extensions_browser_client.cc ('k') | extensions/shell/browser/shell_extensions_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/browser/shell_extensions_browser_client.h

diff --git a/extensions/shell/browser/shell_extensions_browser_client.h b/extensions/shell/browser/shell_extensions_browser_client.h

index 912cabba8c564b6e7a947d08deb706d807d059bb..d0ead54dc9ee680384aecf4aad95e87400cefe18 100644

--- a/extensions/shell/browser/shell_extensions_browser_client.h

+++ b/extensions/shell/browser/shell_extensions_browser_client.h

@@ -71,8 +71,8 @@ class ShellExtensionsBrowserClient : public ExtensionsBrowserClient {

ExtensionFunctionRegistry* registry) const override;

scoped_ptr<RuntimeAPIDelegate> CreateRuntimeAPIDelegate(

content::BrowserContext* context) const override;

- ComponentExtensionResourceManager* GetComponentExtensionResourceManager()

- override;

+ const ComponentExtensionResourceManager*

+ GetComponentExtensionResourceManager() override;

Yoyo Zhou 2015/01/06 00:50:46 nit: this looks odd, is it clang-formatted correct

Jun Mukai 2015/01/06 01:16:50 This is the output of clang-format actually. with

void BroadcastEventToRenderers(const std::string& event_name,

scoped_ptr<base::ListValue> args) override;

net::NetLog* GetNetLog() override;