Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: chrome/browser/resources/options/factory_reset_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/factory_reset_overlay.js
diff --git a/chrome/browser/resources/options/factory_reset_overlay.js b/chrome/browser/resources/options/factory_reset_overlay.js
index a3d3c6e5d74d198a656227db4f4ad7ffdf9c6119..2badca5998852abb3a7304c8b0152e794a7232f6 100644
--- a/chrome/browser/resources/options/factory_reset_overlay.js
+++ b/chrome/browser/resources/options/factory_reset_overlay.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/**
* FactoryResetOverlay class
@@ -11,7 +12,7 @@ cr.define('options', function() {
* @class
*/
function FactoryResetOverlay() {
- OptionsPage.call(this, 'factoryResetData',
+ Page.call(this, 'factoryResetData',
loadTimeData.getString('factoryResetTitle'),
Dan Beam 2014/07/30 01:00:01 indent off
michaelpg 2014/07/30 21:42:19 Done.
'factory-reset-overlay');
}
@@ -19,15 +20,15 @@ cr.define('options', function() {
cr.addSingletonGetter(FactoryResetOverlay);
FactoryResetOverlay.prototype = {
- // Inherit FactoryResetOverlay from OptionsPage.
- __proto__: OptionsPage.prototype,
+ // Inherit FactoryResetOverlay from Page.
+ __proto__: Page.prototype,
/**
* Initialize the page.
*/
initializePage: function() {
// Call base class implementation to starts preference initialization.
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
$('factory-reset-data-dismiss').onclick = function(event) {
FactoryResetOverlay.dismiss();
@@ -39,7 +40,7 @@ cr.define('options', function() {
};
FactoryResetOverlay.dismiss = function() {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
// Export

Powered by Google App Engine
This is Rietveld 408576698