Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Unified Diff: chrome/browser/resources/options/cookies_view.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/cookies_view.js
diff --git a/chrome/browser/resources/options/cookies_view.js b/chrome/browser/resources/options/cookies_view.js
index a6af2978005139dd9d1dee884c4f9e5c3d1e5f0c..f24eeed737b75b785dfd8bd3e9a4116c60e82a56 100644
--- a/chrome/browser/resources/options/cookies_view.js
+++ b/chrome/browser/resources/options/cookies_view.js
@@ -4,7 +4,8 @@
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/////////////////////////////////////////////////////////////////////////////
// CookiesView class:
@@ -14,15 +15,15 @@ cr.define('options', function() {
* @constructor
*/
function CookiesView(model) {
- OptionsPage.call(this, 'cookies',
- loadTimeData.getString('cookiesViewPageTabTitle'),
- 'cookies-view-page');
+ Page.call(this, 'cookies',
+ loadTimeData.getString('cookiesViewPageTabTitle'),
+ 'cookies-view-page');
}
cr.addSingletonGetter(CookiesView);
CookiesView.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/**
* The timer id of the timer set on search query change events.
@@ -39,7 +40,7 @@ cr.define('options', function() {
lastQuery_: '',
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var searchBox = this.pageDiv.querySelector('.cookies-search-box');
searchBox.addEventListener(
@@ -61,7 +62,7 @@ cr.define('options', function() {
this.addEventListener('visibleChange', this.handleVisibleChange_);
this.pageDiv.querySelector('.cookies-view-overlay-confirm').onclick =
- OptionsPage.closeOverlay.bind(OptionsPage);
+ PageManager.closeOverlay.bind(PageManager);
},
/** @override */
@@ -102,7 +103,7 @@ cr.define('options', function() {
initialized_: false,
/**
- * Handler for OptionsPage's visible property change event.
+ * Handler for Page's visible property change event.
* @param {Event} e Property change event.
* @private
*/

Powered by Google App Engine
This is Rietveld 408576698