Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: chrome/browser/resources/options/geolocation_options.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/geolocation_options.js
diff --git a/chrome/browser/resources/options/geolocation_options.js b/chrome/browser/resources/options/geolocation_options.js
index 1215ea9e11f8be6c5ecf54b746a6b0a70cb0e538..ec29fee9c65ebcefd37700f9ea103902c0d77074 100644
--- a/chrome/browser/resources/options/geolocation_options.js
+++ b/chrome/browser/resources/options/geolocation_options.js
@@ -3,7 +3,7 @@
// found in the LICENSE file.
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
/**
* GeolocationOptions class
@@ -12,7 +12,7 @@ cr.define('options', function() {
* @class
*/
function GeolocationOptions() {
- OptionsPage.call(this,
+ Page.call(this,
Dan Beam 2014/07/30 01:00:02 :(
michaelpg 2014/07/30 21:42:19 :)
'geolocationOptions',
loadTimeData.getString('geolocationOptionsPageTabTitle'),
'geolocationCheckbox');
@@ -21,7 +21,7 @@ cr.define('options', function() {
cr.addSingletonGetter(GeolocationOptions);
GeolocationOptions.prototype = {
- __proto__: OptionsPage.prototype
+ __proto__: Page.prototype
};
// TODO(robliao): Determine if a full unroll is necessary

Powered by Google App Engine
This is Rietveld 408576698