Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4346)

Unified Diff: chrome/browser/resources/options/font_settings.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/font_settings.js
diff --git a/chrome/browser/resources/options/font_settings.js b/chrome/browser/resources/options/font_settings.js
index 1d09f5ae8fb3bb7daca039d0968e19aeedf750cd..bc59c882ce975cdf2733072e51dbde553e29e375 100644
--- a/chrome/browser/resources/options/font_settings.js
+++ b/chrome/browser/resources/options/font_settings.js
@@ -5,6 +5,8 @@
cr.define('options', function() {
var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/**
* FontSettings class
@@ -12,22 +14,22 @@ cr.define('options', function() {
* @class
*/
function FontSettings() {
- OptionsPage.call(this,
- 'fonts',
- loadTimeData.getString('fontSettingsPageTabTitle'),
- 'font-settings');
+ Page.call(this,
+ 'fonts',
+ loadTimeData.getString('fontSettingsPageTabTitle'),
+ 'font-settings');
}
cr.addSingletonGetter(FontSettings);
FontSettings.prototype = {
- __proto__: OptionsPage.prototype,
+ __proto__: Page.prototype,
/**
* Initialize the page.
*/
initializePage: function() {
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var standardFontRange = $('standard-font-size');
standardFontRange.valueMap = [9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 20,
@@ -59,7 +61,7 @@ cr.define('options', function() {
});
$('font-settings-confirm').onclick = function() {
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
$('advanced-font-settings-options').onclick = function() {

Powered by Google App Engine
This is Rietveld 408576698