Remove RelatedHistogramSet.

Remove RelatedHistogramSet.

RelatedHistogramSet was designed as a way for metrics to say "all of these
histograms are related to this parent histogram, but the relationship between
the parent and each child is not meaningful". Experience with a few metrics and
further thought has shown that all relationships worth annotating are
meaningful, and deserved to be named via keys in RelatedHistogramMap/Breakdown.
RelatedHistogramSet is currently only used as an implementation detail
(MERGED_FROM, MERGED_TO) to facilitate merging RelatedHistogramSet/Maps and
filtering the histogram-set-table. This usage is replaced with
RelatedHistogramMap using counters for keys.

BUG=catapult:#3661

Review-Url: https://codereview.chromium.org/2998043002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/1353a5dcce233fede2cb172b32aa67bc1063bec7

[benjhayden, 2017-08-18 07:38:14]

benjhayden@chromium.org changed reviewers:
+ eakuefner@chromium.org

[benjhayden, 2017-08-18 07:38:15]

PTAL

[eakuefner, 2017-08-18 23:25:16]

lgtm

[benjhayden, 2017-08-19 04:58:42]

Description was changed from

==========
Remove RelatedHistogramSet.

RelatedHistogramSet was designed as a way for metrics to say "all of these
histograms are related to this parent histogram, but the relationship between
the parent and each child is not meaningful". Experience with a few metrics and
further thought has shown that all relationships worth annotating are
meaningful, and deserved to be named via keys in RelatedHistogramMap/Breakdown.
RelatedHistogramSet is currently only used as an implementation detail
(MERGED_FROM, MERGED_TO) to facilitate merging RelatedHistogramSet/Maps and
filtering the histogram-set-table. This usage can be replaced with
RelatedHistogramMap, using counters or guids or something else equally
meaningless but unique for keys.

BUG=catapult:#3661
==========

to

==========
Remove RelatedHistogramSet.

RelatedHistogramSet was designed as a way for metrics to say "all of these
histograms are related to this parent histogram, but the relationship between
the parent and each child is not meaningful". Experience with a few metrics and
further thought has shown that all relationships worth annotating are
meaningful, and deserved to be named via keys in RelatedHistogramMap/Breakdown.
RelatedHistogramSet is currently only used as an implementation detail
(MERGED_FROM, MERGED_TO) to facilitate merging RelatedHistogramSet/Maps and
filtering the histogram-set-table. This usage is replaced with
RelatedHistogramMap using counters for keys.

BUG=catapult:#3661
==========

[benjhayden, 2017-08-19 17:07:40]

The CQ bit was checked by benjhayden@chromium.org

[commit-bot: I haz the power, 2017-08-19 17:07:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-08-19 17:36:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1503162460848100, "parent_rev":
"ded65295f81032bccd2cd3b7b28d5a759097b52d", "commit_rev":
"1353a5dcce233fede2cb172b32aa67bc1063bec7"}

[commit-bot: I haz the power, 2017-08-19 17:36:44]

Description was changed from

==========
Remove RelatedHistogramSet.

RelatedHistogramSet was designed as a way for metrics to say "all of these
histograms are related to this parent histogram, but the relationship between
the parent and each child is not meaningful". Experience with a few metrics and
further thought has shown that all relationships worth annotating are
meaningful, and deserved to be named via keys in RelatedHistogramMap/Breakdown.
RelatedHistogramSet is currently only used as an implementation detail
(MERGED_FROM, MERGED_TO) to facilitate merging RelatedHistogramSet/Maps and
filtering the histogram-set-table. This usage is replaced with
RelatedHistogramMap using counters for keys.

BUG=catapult:#3661
==========

to

==========
Remove RelatedHistogramSet.

RelatedHistogramSet was designed as a way for metrics to say "all of these
histograms are related to this parent histogram, but the relationship between
the parent and each child is not meaningful". Experience with a few metrics and
further thought has shown that all relationships worth annotating are
meaningful, and deserved to be named via keys in RelatedHistogramMap/Breakdown.
RelatedHistogramSet is currently only used as an implementation detail
(MERGED_FROM, MERGED_TO) to facilitate merging RelatedHistogramSet/Maps and
filtering the histogram-set-table. This usage is replaced with
RelatedHistogramMap using counters for keys.

BUG=catapult:#3661

Review-Url: https://codereview.chromium.org/2998043002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-08-19 17:36:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...