Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1490)

Unified Diff: docs/how-to-write-metrics.md

Issue 2998043002: Remove RelatedHistogramSet. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « docs/histogram-set-json-format.md ('k') | tracing/trace_viewer.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: docs/how-to-write-metrics.md
diff --git a/docs/how-to-write-metrics.md b/docs/how-to-write-metrics.md
index ebe104096d359b8b1962d5b3fb2acb3a6821e260..ba44a85f996aae4a22339408f68c3c14f1917789 100644
--- a/docs/how-to-write-metrics.md
+++ b/docs/how-to-write-metrics.md
@@ -149,21 +149,14 @@ histogram.addSample(number, {name: diagnostic})
### Histogram Relationship Diagnostics
- * [RelatedHistogramSet](/tracing/tracing/value/diagnostics/related_histogram_set.html):
- These are Sets of references to other Histograms. Visually, they are a set
- of HTML links which, when clicked, select the contained Histograms. The text
- content of the HTML link is the name of the referenced Histogram.
-
- ![](/docs/images/how-to-write-metrics-related-histogram-set.png)
-
* [RelatedHistogramMap](/tracing/tracing/value/diagnostics/related_histogram_map.html):
These are Maps from strings to references to other Histograms. Visually, they
- are a set of HTML links similar to RelatedHistogramSet, but the text content of
- the link is the Map's string key instead of the Histogram's name. One example
- application is when a Histogram was produced not directly by a metric, but
- rather by merging together other Histograms, then it will have a
- RelatedHistogramMap named 'mergedFrom' that refers to the Histograms that were
- merged by their grouping key, e.g. the telemetry story name.
+ are a set of HTML links where the text content of the link is the Map's
+ string key instead of the Histogram's name. One example application is when a
+ Histogram was produced not directly by a metric, but rather by merging
+ together other Histograms, then it will have a RelatedHistogramMap named
+ 'mergedFrom' that refers to the Histograms that were merged by their grouping
+ key, e.g. the telemetry story name.
![](/docs/images/how-to-write-metrics-related-histogram-map.png)
@@ -204,9 +197,9 @@ histogram.addSample(number, {name: diagnostic})
unitted number. This is only to allow Histograms in other parts of the trace
viewer to display number sample diagnostics more intelligently than
GenericSet can. If a metric wants to display number sample diagnostics
- intelligently, then it should use RelatedHistogramSet or RelatedHistogramMap;
- if it does not want to monitor changes in those numbers, then the TBM2
- maintainers can add a HistogramDiagnostic that supports merging.
+ intelligently, then it should use RelatedHistogramMap; if it does not want to
+ monitor changes in those numbers, then the TBM2 maintainers can add a
+ HistogramDiagnostic that supports merging.
## Consumers of Histograms
« no previous file with comments | « docs/histogram-set-json-format.md ('k') | tracing/trace_viewer.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698