Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: tracing/tracing/value/histogram_unittest.py

Issue 2998043002: Remove RelatedHistogramSet. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/histogram_set_unittest.py ('k') | tracing/tracing/value/ui/diagnostic_span.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/histogram_unittest.py
diff --git a/tracing/tracing/value/histogram_unittest.py b/tracing/tracing/value/histogram_unittest.py
index a398db905b23078547d0270069bd4b93725521b2..e2c8b4fbd2160a595aac6d37fa74e2e8c7dd4841 100644
--- a/tracing/tracing/value/histogram_unittest.py
+++ b/tracing/tracing/value/histogram_unittest.py
@@ -954,9 +954,8 @@ class DiagnosticMapUnittest(unittest.TestCase):
})
generic = histogram.GenericSet(['generic diagnostic'])
generic2 = histogram.GenericSet(['generic diagnostic 2'])
- related_set = histogram.RelatedHistogramSet([
- histogram.Histogram('histogram', 'count'),
- ])
+ related_map = histogram.RelatedHistogramMap()
+ related_map.Set('a', histogram.Histogram('histogram', 'count'))
hist = histogram.Histogram('', 'count')
@@ -977,13 +976,13 @@ class DiagnosticMapUnittest(unittest.TestCase):
# Merging unmergeable diagnostics should produce an
# UnmergeableDiagnosticSet.
hist4 = histogram.Histogram('', 'count')
- hist4.diagnostics['a'] = related_set
+ hist4.diagnostics['a'] = related_map
hist.diagnostics.Merge(hist4.diagnostics, hist, hist4)
self.assertIsInstance(
hist.diagnostics['a'], histogram.UnmergeableDiagnosticSet)
diagnostics = list(hist.diagnostics['a'])
self.assertIs(generic, diagnostics[0])
- self.assertIs(related_set, diagnostics[1])
+ self.assertIs(related_map, diagnostics[1])
# UnmergeableDiagnosticSets are mergeable.
hist5 = histogram.Histogram('', 'count')
@@ -994,6 +993,6 @@ class DiagnosticMapUnittest(unittest.TestCase):
hist.diagnostics['a'], histogram.UnmergeableDiagnosticSet)
diagnostics = list(hist.diagnostics['a'])
self.assertIs(generic, diagnostics[0])
- self.assertIs(related_set, diagnostics[1])
+ self.assertIs(related_map, diagnostics[1])
self.assertIs(events, diagnostics[2])
self.assertIs(generic2, diagnostics[3])
« no previous file with comments | « tracing/tracing/value/histogram_set_unittest.py ('k') | tracing/tracing/value/ui/diagnostic_span.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698