Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: tracing/tracing/value/histogram_set.html

Issue 2998043002: Remove RelatedHistogramSet. (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/histogram.py ('k') | tracing/tracing/value/histogram_set.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/histogram_set.html
diff --git a/tracing/tracing/value/histogram_set.html b/tracing/tracing/value/histogram_set.html
index 75039e02dd71db4a3abc49002bea17407d5f2af7..5cb581be2fb807f3925608e417fbd90c0200bd90 100644
--- a/tracing/tracing/value/histogram_set.html
+++ b/tracing/tracing/value/histogram_set.html
@@ -152,8 +152,7 @@ tr.exportTo('tr.v', function() {
resolveRelatedHistograms() {
const handleDiagnosticMap = dm => {
for (const [name, diagnostic] of dm) {
- if ((diagnostic instanceof tr.v.d.RelatedHistogramSet) ||
- (diagnostic instanceof tr.v.d.RelatedHistogramMap)) {
+ if (diagnostic instanceof tr.v.d.RelatedHistogramMap) {
diagnostic.resolve(this);
}
}
@@ -178,7 +177,7 @@ tr.exportTo('tr.v', function() {
/**
* Convert dicts to either Histograms or shared Diagnostics.
- * Does not resolve RelatedHistogramSet/RelatedHistogramMap diagnostics. See
+ * Does not resolve RelatedHistogramMap diagnostics. See
* resolveRelatedHistograms().
*
* @param {!Object} dicts
@@ -213,22 +212,18 @@ tr.exportTo('tr.v', function() {
/**
* Find the Histograms that are not contained in any other Histograms'
- * RelatedHistogramSet or RelatedHistogramMap diagnostics.
+ * RelatedHistogramMap diagnostics.
*
* @return {!Array.<!tr.v.Histogram>}
*/
get sourceHistograms() {
const sourceHistograms = new Map(this.histogramsByGuid_);
- // If a Histogram is in a RelatedHistogramSet or RelatedHistogramMap,
+ // If a Histogram is in a RelatedHistogramMap,
// which can be owned either by Histograms or by numeric samples, then it
// is not a source Histogram.
function deleteSourceHistograms(diagnosticMap) {
for (const [name, diagnostic] of diagnosticMap) {
- if (diagnostic instanceof tr.v.d.RelatedHistogramSet) {
- for (const relatedHist of diagnostic) {
- sourceHistograms.delete(relatedHist.guid);
- }
- } else if (diagnostic instanceof tr.v.d.RelatedHistogramMap) {
+ if (diagnostic instanceof tr.v.d.RelatedHistogramMap) {
for (const [name, relatedHist] of diagnostic) {
sourceHistograms.delete(relatedHist.guid);
}
« no previous file with comments | « tracing/tracing/value/histogram.py ('k') | tracing/tracing/value/histogram_set.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698