Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2995243002: Uncomment thread-checkers in ChannelProxy (Closed)

Created:
3 years, 4 months ago by eladalon
Modified:
3 years, 3 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Uncomment thread-checkers in ChannelProxy The thread-check should be pass unit-tests, following https://codereview.webrtc.org/2998923002/. BUG=webrtc:7405 TBR=stefan@webrtc.org Review-Url: https://codereview.webrtc.org/2995243002 Cr-Commit-Position: refs/heads/master@{#19510} Committed: https://chromium.googlesource.com/external/webrtc/+/27e812e36927e15401259e6a1a2cd01b9fdd4f79

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : One check cannot be un-commented yet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M webrtc/voice_engine/channel_proxy.cc View 1 2 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
eladalon
PTAL
3 years, 4 months ago (2017-08-21 08:41:22 UTC) #2
nisse-webrtc
lgtm
3 years, 4 months ago (2017-08-23 12:32:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995243002/20001
3 years, 4 months ago (2017-08-24 14:38:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_baremetal on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/23848)
3 years, 4 months ago (2017-08-24 14:58:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2995243002/40001
3 years, 3 months ago (2017-08-25 08:25:28 UTC) #11
commit-bot: I haz the power
3 years, 3 months ago (2017-08-25 08:51:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/27e812e36927e15401259e6a1...

Powered by Google App Engine
This is Rietveld 408576698