Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: webrtc/voice_engine/channel_proxy.cc

Issue 2995243002: Uncomment thread-checkers in ChannelProxy (Closed)
Patch Set: One check cannot be un-commented yet. Created 3 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); 312 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
313 channel()->SetRtcpRttStats(rtcp_rtt_stats); 313 channel()->SetRtcpRttStats(rtcp_rtt_stats);
314 } 314 }
315 315
316 bool ChannelProxy::GetRecCodec(CodecInst* codec_inst) const { 316 bool ChannelProxy::GetRecCodec(CodecInst* codec_inst) const {
317 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); 317 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
318 return channel()->GetRecCodec(*codec_inst) == 0; 318 return channel()->GetRecCodec(*codec_inst) == 0;
319 } 319 }
320 320
321 void ChannelProxy::OnTwccBasedUplinkPacketLossRate(float packet_loss_rate) { 321 void ChannelProxy::OnTwccBasedUplinkPacketLossRate(float packet_loss_rate) {
322 // TODO(eladalon): This fails in UT; fix and uncomment. 322 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
323 // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
324 // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
325 channel()->OnTwccBasedUplinkPacketLossRate(packet_loss_rate); 323 channel()->OnTwccBasedUplinkPacketLossRate(packet_loss_rate);
326 } 324 }
327 325
328 void ChannelProxy::OnRecoverableUplinkPacketLossRate( 326 void ChannelProxy::OnRecoverableUplinkPacketLossRate(
329 float recoverable_packet_loss_rate) { 327 float recoverable_packet_loss_rate) {
330 // TODO(eladalon): This fails in UT; fix and uncomment. 328 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
331 // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
332 // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
333 channel()->OnRecoverableUplinkPacketLossRate(recoverable_packet_loss_rate); 329 channel()->OnRecoverableUplinkPacketLossRate(recoverable_packet_loss_rate);
334 } 330 }
335 331
336 void ChannelProxy::RegisterLegacyReceiveCodecs() { 332 void ChannelProxy::RegisterLegacyReceiveCodecs() {
337 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); 333 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
338 channel()->RegisterLegacyReceiveCodecs(); 334 channel()->RegisterLegacyReceiveCodecs();
339 } 335 }
340 336
341 std::vector<RtpSource> ChannelProxy::GetSources() const { 337 std::vector<RtpSource> ChannelProxy::GetSources() const {
342 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread()); 338 RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
343 return channel()->GetSources(); 339 return channel()->GetSources();
344 } 340 }
345 341
346 Channel* ChannelProxy::channel() const { 342 Channel* ChannelProxy::channel() const {
347 RTC_DCHECK(channel_owner_.channel()); 343 RTC_DCHECK(channel_owner_.channel());
348 return channel_owner_.channel(); 344 return channel_owner_.channel();
349 } 345 }
350 346
351 } // namespace voe 347 } // namespace voe
352 } // namespace webrtc 348 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698