Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: webrtc/voice_engine/channel_proxy.cc

Issue 2995243002: Uncomment thread-checkers in ChannelProxy (Closed)
Patch Set: One check cannot be un-commented yet. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/channel_proxy.cc
diff --git a/webrtc/voice_engine/channel_proxy.cc b/webrtc/voice_engine/channel_proxy.cc
index 027659d2f0ec09e7534c84c484b840e5f42ed95c..cdd4b6624ff53612ffacfceeebecf37d5dd98c1c 100644
--- a/webrtc/voice_engine/channel_proxy.cc
+++ b/webrtc/voice_engine/channel_proxy.cc
@@ -319,17 +319,13 @@ bool ChannelProxy::GetRecCodec(CodecInst* codec_inst) const {
}
void ChannelProxy::OnTwccBasedUplinkPacketLossRate(float packet_loss_rate) {
- // TODO(eladalon): This fails in UT; fix and uncomment.
- // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
- // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
+ RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
channel()->OnTwccBasedUplinkPacketLossRate(packet_loss_rate);
}
void ChannelProxy::OnRecoverableUplinkPacketLossRate(
float recoverable_packet_loss_rate) {
- // TODO(eladalon): This fails in UT; fix and uncomment.
- // See: https://bugs.chromium.org/p/webrtc/issues/detail?id=7405
- // RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
+ RTC_DCHECK(worker_thread_checker_.CalledOnValidThread());
channel()->OnRecoverableUplinkPacketLossRate(recoverable_packet_loss_rate);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698