Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2958483003: Make VisiblePosition::BeforeNode() to take const Node& instead of Node* (Closed)

Created:
3 years, 6 months ago by yosin_UTC9
Modified:
3 years, 6 months ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make VisiblePosition::BeforeNode() to take const Node& instead of Node* This patch makes |VisiblePosition::BeforeNode()| to take |const Node&| as |Position::BeforeNode()| for improving code health. This is mechanical change: s/VisiblePositon::BeforeNode(/VisiblePositon::BeforeNode(*/ BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2958483003 Cr-Commit-Position: refs/heads/master@{#482193} Committed: https://chromium.googlesource.com/chromium/src/+/4ce716d53ef2929a0515d2b12aea0b786b4024eb

Patch Set 1 : 017-06-23T18:57:25 #

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL
3 years, 6 months ago (2017-06-23 10:00:54 UTC) #6
Xiaocheng
lgtm
3 years, 6 months ago (2017-06-23 17:31:38 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2958483003/1
3 years, 6 months ago (2017-06-26 02:01:40 UTC) #11
commit-bot: I haz the power
3 years, 6 months ago (2017-06-26 03:53:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4ce716d53ef2929a0515d2b12aea...

Powered by Google App Engine
This is Rietveld 408576698