Make VisiblePosition::BeforeNode() to take const Node& instead of Node*

third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009, 2010, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 916 matching lines @@
     InsertNodeBefore(placeholder,
                      start_of_paragraph_to_move.DeepEquivalent().AnchorNode(),
                      editing_state);
     if (editing_state->IsAborted())
       return;
 
     // TODO(editing-dev): Use of updateStyleAndLayoutIgnorePendingStylesheets()
     // needs to be audited.  See http://crbug.com/590369 for more details.
     GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
 
-    destination = VisiblePosition::BeforeNode(placeholder);
+    destination = VisiblePosition::BeforeNode(*placeholder);
     start_of_paragraph_to_move = CreateVisiblePosition(
         start_of_paragraph_to_move.ToPositionWithAffinity());
   }
 
   MoveParagraph(start_of_paragraph_to_move,
                 EndOfParagraph(start_of_paragraph_to_move), destination,
                 editing_state);
   if (editing_state->IsAborted())
     return;
 
@@ skipping 229 matching lines @@
   // changed to mean the last position after p that maps to the same visible
   // position as p (since in the case where a br is at the end of a block and
   // collapsed away, there are positions after the br which map to the same
   // visible position as [br, 0]).
   HTMLBRElement* end_br =
       isHTMLBRElement(*MostForwardCaretPosition(insertion_pos).AnchorNode())
           ? toHTMLBRElement(
                 MostForwardCaretPosition(insertion_pos).AnchorNode())
           : 0;
   VisiblePosition original_vis_pos_before_end_br;
-  if (end_br)
+  if (end_br) {
     original_vis_pos_before_end_br =
-        PreviousPositionOf(VisiblePosition::BeforeNode(end_br));
+        PreviousPositionOf(VisiblePosition::BeforeNode(*end_br));
+  }
 
   Element* enclosing_block_of_insertion_pos =
       EnclosingBlock(insertion_pos.AnchorNode());
 
   // Adjust |enclosingBlockOfInsertionPos| to prevent nesting.
   // If the start was in a Mail blockquote, we will have already handled
   // adjusting |enclosingBlockOfInsertionPos| above.
   if (prevent_nesting_ && enclosing_block_of_insertion_pos &&
       enclosing_block_of_insertion_pos != current_root &&
       !IsTableCell(enclosing_block_of_insertion_pos) &&
@@ skipping 390 matching lines @@
 
   CompleteHTMLReplacement(last_position_to_select, editing_state);
 }
 
 bool ReplaceSelectionCommand::ShouldRemoveEndBR(
     HTMLBRElement* end_br,
     const VisiblePosition& original_vis_pos_before_end_br) {
   if (!end_br || !end_br->isConnected())
     return false;
 
-  VisiblePosition visible_pos = VisiblePosition::BeforeNode(end_br);
+  VisiblePosition visible_pos = VisiblePosition::BeforeNode(*end_br);
 
   // Don't remove the br if nothing was inserted.
   if (PreviousPositionOf(visible_pos).DeepEquivalent() ==
       original_vis_pos_before_end_br.DeepEquivalent())
     return false;
 
   // Remove the br if it is collapsed away and so is unnecessary.
   if (!GetDocument().InNoQuirksMode() && IsEndOfBlock(visible_pos) &&
       !IsStartOfParagraph(visible_pos))
     return true;
@@ skipping 362 matching lines @@
   Position end = ReplaceSelectedTextInNode(text_node->data());
   if (end.IsNull())
     return false;
 
   GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();
 
   if (node_after_insertion_pos && node_after_insertion_pos->parentNode() &&
       isHTMLBRElement(*node_after_insertion_pos) &&
       ShouldRemoveEndBR(
           toHTMLBRElement(node_after_insertion_pos),
-          VisiblePosition::BeforeNode(node_after_insertion_pos))) {
+          VisiblePosition::BeforeNode(*node_after_insertion_pos))) {
     RemoveNodeAndPruneAncestors(node_after_insertion_pos, editing_state);
     if (editing_state->IsAborted())
       return false;
   }
 
   start_of_inserted_range_ = start;
   end_of_inserted_range_ = end;
 
   SetEndingSelection(
       SelectionInDOMTree::Builder()
@@ skipping 15 matching lines @@
   visitor->Trace(start_of_inserted_content_);
   visitor->Trace(end_of_inserted_content_);
   visitor->Trace(insertion_style_);
   visitor->Trace(document_fragment_);
   visitor->Trace(start_of_inserted_range_);
   visitor->Trace(end_of_inserted_range_);
   CompositeEditCommand::Trace(visitor);
 }
 
 }  // namespace blink