third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp - Issue 2958483003: Make VisiblePosition::BeforeNode() to take const Node& instead of Node*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

Issue 2958483003: Make VisiblePosition::BeforeNode() to take const Node& instead of Node* (Closed)

Patch Set: 017-06-23T18:57:25 Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp ('k') | third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

index 760d55c9a1525f7a6e596380edb777445959d1cb..e2f5bfcfc91cc3f1ef83d2be8ba847126b90d6d9 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp

@@ -538,7 +538,7 @@ void InsertParagraphSeparatorCommand::DoApply(EditingState* editing_state) {

// Move the start node and the siblings of the start node.

if (CreateVisiblePosition(insertion_position).DeepEquivalent() !=

- VisiblePosition::BeforeNode(block_to_insert).DeepEquivalent()) {

+ VisiblePosition::BeforeNode(*block_to_insert).DeepEquivalent()) {

Node* n;

if (insertion_position.ComputeContainerNode() == start_block) {

n = insertion_position.ComputeNodeAfterPosition();

@@ -554,7 +554,7 @@ void InsertParagraphSeparatorCommand::DoApply(EditingState* editing_state) {

GetDocument().UpdateStyleAndLayoutIgnorePendingStylesheets();

for (n = start_block->firstChild(); n; n = n->nextSibling()) {

- VisiblePosition before_node_position = VisiblePosition::BeforeNode(n);

+ VisiblePosition before_node_position = VisiblePosition::BeforeNode(*n);

if (!before_node_position.IsNull() &&

ComparePositions(CreateVisiblePosition(insertion_position),

before_node_position) <= 0)