Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2956583002: Removed usage of RefPtr::Release in unit tests (Closed)

Created:
3 years, 6 months ago by Bugs Nash
Modified:
3 years, 5 months ago
CC:
darktears, atotic+reviews_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-worker-reviews_chromium.org, Rik, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, falken+watch_chromium.org, fmalita+watch_chromium.org, glebl+reviews_chromium.org, haraken, horo+watch_chromium.org, jchaffraix+rendering, Justin Novosad, kinuko+worker_chromium.org, kinuko+watch, lchoi+reviews_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, piman+watch_chromium.org, platform-architecture-syd+reviews-web_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, shimazu+worker_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed usage of RefPtr::Release in unit tests Replaced with std::move wraps where move is not automatic. Removed call to Release where move is automatic (i.e. returning local RefPtr object) As PassRefPtr is still in use this introduces implicit conversions from RefPtr to PassRefPtr. Future patches will change the PassRefPtr nstances to RefPtr. BUG=494719 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_layout_ng Review-Url: https://codereview.chromium.org/2956583002 Cr-Commit-Position: refs/heads/master@{#482177} Committed: https://chromium.googlesource.com/chromium/src/+/20fca46b45d56973beb701dfcd4f77a433077a39

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
Bugs Nash
3 years, 6 months ago (2017-06-23 06:03:58 UTC) #5
haraken
LGTM
3 years, 6 months ago (2017-06-23 06:10:59 UTC) #6
Yuta Kitamura
lgtm
3 years, 6 months ago (2017-06-23 06:22:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2956583002/1
3 years, 6 months ago (2017-06-25 22:01:33 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-06-25 23:33:46 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20fca46b45d56973beb701dfcd4f...

Powered by Google App Engine
This is Rietveld 408576698