Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: third_party/WebKit/Source/web/tests/MHTMLTest.cpp

Issue 2956583002: Removed usage of RefPtr::Release in unit tests (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 } 165 }
166 MHTMLArchive::GenerateMHTMLFooterForTesting(boundary, 166 MHTMLArchive::GenerateMHTMLFooterForTesting(boundary,
167 *mhtml_data->MutableData()); 167 *mhtml_data->MutableData());
168 168
169 // Validate the generated MHTML. 169 // Validate the generated MHTML.
170 MHTMLParser parser( 170 MHTMLParser parser(
171 SharedBuffer::Create(mhtml_data->data(), mhtml_data->length())); 171 SharedBuffer::Create(mhtml_data->data(), mhtml_data->length()));
172 EXPECT_FALSE(parser.ParseArchive().IsEmpty()) 172 EXPECT_FALSE(parser.ParseArchive().IsEmpty())
173 << "Generated MHTML is malformed"; 173 << "Generated MHTML is malformed";
174 174
175 return mhtml_data.Release(); 175 return mhtml_data;
176 } 176 }
177 177
178 PassRefPtr<RawData> Serialize(const char* title, 178 PassRefPtr<RawData> Serialize(const char* title,
179 const char* mime, 179 const char* mime,
180 MHTMLArchive::EncodingPolicy encoding_policy) { 180 MHTMLArchive::EncodingPolicy encoding_policy) {
181 return GenerateMHTMLData(resources_, encoding_policy, title, mime); 181 return GenerateMHTMLData(resources_, encoding_policy, title, mime);
182 } 182 }
183 183
184 private: 184 private:
185 PassRefPtr<SharedBuffer> ReadFile(const char* file_name) { 185 PassRefPtr<SharedBuffer> ReadFile(const char* file_name) {
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 .getElementById("s1")); 331 .getElementById("s1"));
332 // The element to be created by the script in the shadow dom template is 332 // The element to be created by the script in the shadow dom template is
333 // not found because the script is blocked. 333 // not found because the script is blocked.
334 EXPECT_FALSE(document->getElementById("h4") 334 EXPECT_FALSE(document->getElementById("h4")
335 ->Shadow() 335 ->Shadow()
336 ->OldestShadowRoot() 336 ->OldestShadowRoot()
337 .getElementById("s2")); 337 .getElementById("s2"));
338 } 338 }
339 339
340 } // namespace blink 340 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/platform/wtf/FunctionalTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698