third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp - Issue 2956583002: Removed usage of RefPtr::Release in unit tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp

Issue 2956583002: Removed usage of RefPtr::Release in unit tests (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationSimTest.cpp ('k') | third_party/WebKit/Source/core/layout/ng/inline/ng_inline_items_builder_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp

diff --git a/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp b/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp

index b29fea5b5adc3088dce319405832868bf7daba6a..2a1d7540629590d4a8e8e1a1da576825f812d074 100644

--- a/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp

+++ b/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp

@@ -386,12 +386,12 @@ TEST_F(AnimationCompositorAnimationsTest,

keyframe->SetOffset(0);

keyframe->SetPropertyValue(CSSPropertyColor, AnimatableDouble::Create(0));

keyframe->SetPropertyValue(CSSPropertyOpacity, AnimatableDouble::Create(0));

- frames_mixed_properties.push_back(keyframe.Release());

+ frames_mixed_properties.push_back(std::move(keyframe));

keyframe = AnimatableValueKeyframe::Create();

keyframe->SetOffset(1);

keyframe->SetPropertyValue(CSSPropertyColor, AnimatableDouble::Create(1));

keyframe->SetPropertyValue(CSSPropertyOpacity, AnimatableDouble::Create(1));

- frames_mixed_properties.push_back(keyframe.Release());

+ frames_mixed_properties.push_back(std::move(keyframe));

EXPECT_FALSE(CanStartEffectOnCompositor(

timing_,

*AnimatableValueKeyframeEffectModel::Create(frames_mixed_properties)));