Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2954873002: Add DVLOG_IS_ON() in preparation for adding dvlog_always_on in chromium project.

Created:
3 years, 6 months ago by hiroh
Modified:
3 years, 6 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DVLOG_IS_ON() in preparation for adding dvlog_always_on in chromium project. dvlog_always_on make DLOG() and DVLOG() enable without DEBUG and DCHECK option. This is useful because dvlog_always_on does not enable DCHECK(), and therefore, the program is not failed due to DCHECK(). BUG=None Test=Seeing DVLOGs and DLOGs are shown.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WindowProxy.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hiroh
dvlog_always_on will be added in chromium, which enables DLOG() and DVLOGS() without DEBUG and DCHECK ...
3 years, 6 months ago (2017-06-26 05:20:48 UTC) #2
Yuki
LGTM.
3 years, 6 months ago (2017-06-26 05:31:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2954873002/1
3 years, 6 months ago (2017-06-26 05:32:09 UTC) #5
haraken
LGTM
3 years, 6 months ago (2017-06-26 05:32:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/325338) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-26 05:42:19 UTC) #8
hiroh
3 years, 6 months ago (2017-06-26 06:19:49 UTC) #9
The compilation is failed because there is no definition of DVLOG_IS_ON().
This patch should be merged after adopting dvlog_always_on is approved.
Therefore, merging work flow is:
1) Approve adopting dvlog_always_on in crrev.com/2954883002.
2) merge this CL by fixing by adding locally DVLOG_IS_ON() definition like
follows.
#ifndef DVLOG_IS_ON
#define DVLOG_IS_ON() 0
#endif
3) merge the CL for adding dvlog_always_on chromium (crrev.com/2954883002).
4) merge yet another CL to get rid of local DVLOG_IS_ON() in Blink.

Powered by Google App Engine
This is Rietveld 408576698