third_party/WebKit/Source/bindings/core/v8/WindowProxy.h - Issue 2954873002: Add DVLOG_IS_ON() in preparation for adding dvlog_always_on in chromium project.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

Issue 2954873002: Add DVLOG_IS_ON() in preparation for adding dvlog_always_on in chromium project.

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

index f42a069a37c75a683c9e6b2b8f4c576b8be76f6b..5d1c4ff5dacefa3fa9528c6e73de93dd187c5799 100644

--- a/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

+++ b/third_party/WebKit/Source/bindings/core/v8/WindowProxy.h

@@ -237,7 +237,7 @@ class WindowProxy : public GarbageCollectedFinalized<WindowProxy> {

v8::Isolate* GetIsolate() const { return isolate_; }

Frame* GetFrame() const { return frame_.Get(); }

-#if DCHECK_IS_ON()

+#if DCHECK_IS_ON() || DVLOG_IS_ON()

void DidAttachGlobalObject() { is_global_object_attached_ = true; }

void DidDetachGlobalObject() { is_global_object_attached_ = false; }

#endif

@@ -245,7 +245,7 @@ class WindowProxy : public GarbageCollectedFinalized<WindowProxy> {

private:

v8::Isolate* const isolate_;

const Member<Frame> frame_;

-#if DCHECK_IS_ON()

+#if DCHECK_IS_ON() || DVLOG_IS_ON()

bool is_global_object_attached_ = false;

#endif

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp ('k') | no next file » | no next file with comments »