third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp - Issue 2954873002: Add DVLOG_IS_ON() in preparation for adding dvlog_always_on in chromium project.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

Issue 2954873002: Add DVLOG_IS_ON() in preparation for adding dvlog_always_on in chromium project.

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

index d1fae091af48f28e81d8422d2a2e3691edb179fa..0f02f9612d3637d6ec55aca288a7066e40cbdf41 100644

--- a/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.cpp

@@ -61,7 +61,7 @@ void RemoteWindowProxy::DisposeContext(Lifecycle next_status) {

global_proxy_.Get().SetWrapperClassId(0);

V8DOMWrapper::ClearNativeInfo(GetIsolate(),

global_proxy_.NewLocal(GetIsolate()));

-#if DCHECK_IS_ON()

+#if DCHECK_IS_ON() || DVLOG_IS_ON()

DidDetachGlobalObject();

#endif

}

@@ -108,7 +108,7 @@ void RemoteWindowProxy::CreateContext() {

DCHECK(global_proxy_.Get() == global_proxy);

CHECK(!global_proxy_.IsEmpty());

-#if DCHECK_IS_ON()

+#if DCHECK_IS_ON() || DVLOG_IS_ON()

DidAttachGlobalObject();

#endif