Revert of [arm] Share constant pool entries in snapshot.

Revert of [arm] Share constant pool entries in snapshot. (patchset #3 id:40001 of https://codereview.chromium.org/2869683004/ )

Reason for revert:
Breaks OSR in full-codegen because the constant pool entry being patched is shared accross different OSR points. This is tracked by: https://bugs.chromium.org/p/chromium/issues/detail?id=725743

Original issue's description:
> [arm] Share constant pool entries in snapshot.
> 
> This patch also adds sharing of code target entries, which requires
> sharing the RelocInfo for those entries as well. The disassembler
> is also modified in order to print comments for the RelocInfo that
> is now shared.
> 
> This improves the snapshot size for arm by about 4%.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2869683004
> Cr-Commit-Position: refs/heads/master@{#45497}
> Committed: https://chromium.googlesource.com/v8/v8/+/c15b3ffc773ef7b14655b59b1ce1437de903fdc0

TBR=bmeurer@chromium.org,hpayer@chromium.org,jarin@chromium.org,mvstanton@chromium.org,rmcilroy@chromium.org,clemensh@chromium.org,georgia.kouveli@arm.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=

[Michael Starzinger, 2017-05-30 10:47:40]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2017-05-30 10:47:40]

Created Revert of [arm] Share constant pool entries in snapshot.

[commit-bot: I haz the power, 2017-05-30 10:47:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 10:48:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 10:48:53]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gcc_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gcc_compile_dbg/...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/26675)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/26581)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/23239)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/42037)

[Clemens Hammacher, 2017-06-11 10:13:30]

Is this still relevant, or can it be closed?

[Michael Starzinger, 2017-06-12 08:15:42]

On 2017/06/11 10:13:30, Clemens Hammacher wrote:
> Is this still relevant, or can it be closed?

Nope, no longer relevant. Can be closed.

[Michael Starzinger, 2017-06-12 08:15:49]

Description was changed from

==========
Revert of [arm] Share constant pool entries in snapshot. (patchset #3 id:40001
of https://codereview.chromium.org/2869683004/ )

Reason for revert:
Breaks OSR in full-codegen because the constant pool entry being patched is
shared accross different OSR points. This is tracked by:
https://bugs.chromium.org/p/chromium/issues/detail?id=725743

Original issue's description:
> [arm] Share constant pool entries in snapshot.
> 
> This patch also adds sharing of code target entries, which requires
> sharing the RelocInfo for those entries as well. The disassembler
> is also modified in order to print comments for the RelocInfo that
> is now shared.
> 
> This improves the snapshot size for arm by about 4%.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2869683004
> Cr-Commit-Position: refs/heads/master@{#45497}
> Committed:
https://chromium.googlesource.com/v8/v8/+/c15b3ffc773ef7b14655b59b1ce1437de90...

TBR=bmeurer@chromium.org,hpayer@chromium.org,jarin@chromium.org,mvstanton@chr...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
==========

to

==========
Revert of [arm] Share constant pool entries in snapshot. (patchset #3 id:40001
of https://codereview.chromium.org/2869683004/ )

Reason for revert:
Breaks OSR in full-codegen because the constant pool entry being patched is
shared accross different OSR points. This is tracked by:
https://bugs.chromium.org/p/chromium/issues/detail?id=725743

Original issue's description:
> [arm] Share constant pool entries in snapshot.
> 
> This patch also adds sharing of code target entries, which requires
> sharing the RelocInfo for those entries as well. The disassembler
> is also modified in order to print comments for the RelocInfo that
> is now shared.
> 
> This improves the snapshot size for arm by about 4%.
> 
> BUG=
> 
> Review-Url: https://codereview.chromium.org/2869683004
> Cr-Commit-Position: refs/heads/master@{#45497}
> Committed:
https://chromium.googlesource.com/v8/v8/+/c15b3ffc773ef7b14655b59b1ce1437de90...

TBR=bmeurer@chromium.org,hpayer@chromium.org,jarin@chromium.org,mvstanton@chr...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=
==========