Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/heap/heap.cc

Issue 2912063002: Revert of [arm] Share constant pool entries in snapshot. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/disassembler.cc ('k') | src/interpreter/setup-interpreter-internal.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/heap/heap.h" 5 #include "src/heap/heap.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api.h" 8 #include "src/api.h"
9 #include "src/assembler-inl.h" 9 #include "src/assembler-inl.h"
10 #include "src/ast/context-slot-cache.h" 10 #include "src/ast/context-slot-cache.h"
(...skipping 2605 matching lines...) Expand 10 before | Expand all | Expand 10 after
2616 set_js_construct_entry_code(*stub.GetCode()); 2616 set_js_construct_entry_code(*stub.GetCode());
2617 } 2617 }
2618 2618
2619 2619
2620 void Heap::CreateFixedStubs() { 2620 void Heap::CreateFixedStubs() {
2621 // Here we create roots for fixed stubs. They are needed at GC 2621 // Here we create roots for fixed stubs. They are needed at GC
2622 // for cooking and uncooking (check out frames.cc). 2622 // for cooking and uncooking (check out frames.cc).
2623 // The eliminates the need for doing dictionary lookup in the 2623 // The eliminates the need for doing dictionary lookup in the
2624 // stub cache for these stubs. 2624 // stub cache for these stubs.
2625 HandleScope scope(isolate()); 2625 HandleScope scope(isolate());
2626 // Canonicalize handles, so that we can share constant pool entries pointing
2627 // to code targets without dereferencing their handles.
2628 CanonicalHandleScope canonical(isolate());
2629 2626
2630 // Create stubs that should be there, so we don't unexpectedly have to 2627 // Create stubs that should be there, so we don't unexpectedly have to
2631 // create them if we need them during the creation of another stub. 2628 // create them if we need them during the creation of another stub.
2632 // Stub creation mixes raw pointers and handles in an unsafe manner so 2629 // Stub creation mixes raw pointers and handles in an unsafe manner so
2633 // we cannot create stubs while we are creating stubs. 2630 // we cannot create stubs while we are creating stubs.
2634 CodeStub::GenerateStubsAheadOfTime(isolate()); 2631 CodeStub::GenerateStubsAheadOfTime(isolate());
2635 2632
2636 // MacroAssembler::Abort calls (usually enabled with --debug-code) depend on 2633 // MacroAssembler::Abort calls (usually enabled with --debug-code) depend on
2637 // CEntryStub, so we need to call GenerateStubsAheadOfTime before JSEntryStub 2634 // CEntryStub, so we need to call GenerateStubsAheadOfTime before JSEntryStub
2638 // is created. 2635 // is created.
(...skipping 3892 matching lines...) Expand 10 before | Expand all | Expand 10 after
6531 case LO_SPACE: 6528 case LO_SPACE:
6532 return "LO_SPACE"; 6529 return "LO_SPACE";
6533 default: 6530 default:
6534 UNREACHABLE(); 6531 UNREACHABLE();
6535 } 6532 }
6536 return NULL; 6533 return NULL;
6537 } 6534 }
6538 6535
6539 } // namespace internal 6536 } // namespace internal
6540 } // namespace v8 6537 } // namespace v8
OLDNEW
« no previous file with comments | « src/disassembler.cc ('k') | src/interpreter/setup-interpreter-internal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698