Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2851053002: Fix detached event listener attribute updating. (Closed)

Created:
3 years, 7 months ago by sof
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix detached event listener attribute updating. R= BUG=714353

Patch Set 1 #

Patch Set 2 : Push Document lookup down #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
A third_party/WebKit/LayoutTests/fast/events/event-listener-detached.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp View 1 1 chunk +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventListener.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (8 generated)
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 7 months ago (2017-04-29 07:37:59 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851053002/1
3 years, 7 months ago (2017-04-29 07:38:02 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-29 09:25:05 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/433161)
3 years, 7 months ago (2017-04-29 09:25:06 UTC) #4
sof
The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run
3 years, 7 months ago (2017-04-29 15:02:54 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851053002/20001
3 years, 7 months ago (2017-04-29 15:03:06 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-04-29 16:58:04 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-29 16:58:05 UTC) #8 
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698